ServiceExport with ExportedPorts now respects TargetGroupPolicy protocol settings #854
+542
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
#853
What does this PR do / Why do we need it:
This PR fixes a bug where ServiceExport resources with the
exportedPortsfield were ignoring protocol and protocolVersion settings from TargetGroupPolicy. The target groups were always created using the default protocol inferred from therouteTypefield, preventing users from configuring HTTPS or other non-default protocols.Changes made:
buildTargetGroupForExportedPortmethod to parse and apply protocol/protocolVersion from TargetGroupPolicyWhy we need this:
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A
Testing done on this change:
Yes, additional unit and integration tests added.
Automation added to e2e:
Yes - Added comprehensive integration test suite in
test/suites/integration/targetgrouppolicy_serviceexport_test.go:TargetGroupPolicy ServiceExport with ExportedPorts Integration TestsWill this PR introduce any new dependencies?:
No. This PR only modifies existing code logic without adding new dependencies, APIs, or external calls.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No breaking changes. This fix maintains full backward compatibility.
Does this PR introduce any user-facing change?:
Yes - Users can now configure protocol overrides for ServiceExport with exportedPorts using TargetGroupPolicy.
Do all end-to-end tests successfully pass when running
make e2e-test?:Yes, all tests pass including the new integration tests for this fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.