fix(bedrock-alpha): added missing validation when prompt uses default variant #35366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Aug 29, 2025
alvazjor
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
alvazjor
added
pr/needs-maintainer-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
alvazjor
added
p1
and removed
pr/needs-maintainer-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
kumsmrit
approved these changes
Sep 9, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
When using Prompts and PromptVariants in bedrock, you can define the default variant your prompt will use, but if you dont add it to the variants array too, it will fail at deployment time.
Description of changes
Added a validation that checks the correct conditions at synth time, so you don't waste time and leave a stack with a bad deployment
Describe any new or updated permissions being added
NA
Description of how you validated changes
Unit tests. We don't create integ tests for validations (synth time) as they wont add any additional value
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license