-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Bump awscrt from 0.27.6 to 0.28.1 #9735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
8
commits into
v2
Choose a base branch
from
dependabot/pip/v2/awscrt-0.28.1
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
753546d
Bump awscrt from 0.27.6 to 0.28.1
dependabot[bot] d65ca8c
Regenerate lock files for macOS and Linux
c89eb10
Regenerate lock files for Windows
da6c941
Add changelog entry
hssyoo 7666afd
Expose CRT file IO options
hssyoo 587d28b
Add tests
hssyoo eb02eea
Docs and changelog
hssyoo b0febfa
Address feedback
hssyoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"type": "enhancement", | ||
"category": "``awscrt``", | ||
"description": "Update awscrt version to 0.28.1" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"type": "enhancement", | ||
"category": "awscrt", | ||
"description": "Exposes new CRT options for S3 file IO" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hssyoo marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -382,6 +382,50 @@ adjustments mid-transfer command in order to increase throughput and reach the | |
requested bandwidth. | ||
|
||
|
||
should_stream | ||
------------- | ||
.. note:: | ||
This configuration option is only supported when the ``preferred_transfer_client`` | ||
configuration value is set to or resolves to ``crt``. The ``classic`` transfer | ||
client does not support this configuration option. | ||
|
||
**Default** - ``false`` | ||
|
||
If set to ``true``, the CRT client will skip buffering parts in-memory before | ||
sending PUT requests. | ||
|
||
|
||
disk_throughput | ||
--------------- | ||
.. note:: | ||
This configuration option is only supported when the ``preferred_transfer_client`` | ||
configuration value is set to or resolves to ``crt``. The ``classic`` transfer | ||
client does not support this configuration option. | ||
|
||
**Default** - ``10.0`` | ||
|
||
The estimated target disk throughput. This value is only applied if | ||
``should_stream`` is set to ``true``.This value can be specified using | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor nit: There's a missing space after |
||
the same semantics as ``target_throughput``, that is either as the | ||
number of bytes per second as an integer, or using a rate suffix. | ||
|
||
|
||
direct_io | ||
--------- | ||
.. note:: | ||
This configuration option is only supported when the ``preferred_transfer_client`` | ||
configuration value is set to or resolves to ``crt``. The ``classic`` transfer | ||
client does not support this configuration option. | ||
|
||
.. note:: | ||
This configuration option is only supported on Linux. | ||
|
||
**Default** - ``false`` | ||
|
||
If set to ``true``, the CRT client will enable direct IO to bypass the OS | ||
cache when sending PUT requests. Enabling direct IO may be useful in cases | ||
where the disk IO outperforms the kernel cache. | ||
|
||
Experimental Configuration Values | ||
================================= | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.