Add exec-profile arguments to eks update-kubeconfig #9760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using the current session profile to generate the config, while using a different profile within the configuration. Fixes aws#9759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#9759
Description of changes:
Adds
--exec-profileargument toeks update-kubeconfig. When set, this profile will be set asAWS_PROFILEwithin the generated kubeconfig. This allows for using one profile (the session profile) to generate the config, without requiring that same profile for connecting to the cluster or for assuming the--role-arn.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I was unable to find any documentation on how to set up this repository for local development, so I'm not sure that my added unit test actually passes. We shall see what the CI says.