-
Notifications
You must be signed in to change notification settings - Fork 694
feat(auth): add IAM credentials LSP requests to AuthUtils and auth2 #7507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bywang56
pushed a commit
that referenced
this pull request
Jul 31, 2025
#7659) ## Problem The webview does not support IAM credentials input and endpoint to LSP does not support IAM credentials and IAM profiles. ## Solution This is part of #7507. - Add IAM credentials option and form to webview - Modify AuthUtils to switch between SsoLogin and IamLogin strategies - Add startIamCredentialSetup in backend_amazonq Meanwhile, we are making changes to language-servers and language-server-runtimes such that authentication for IAM credentials can happen on Flare side. working branches: https://github.com/liramon1/language-server-runtimes/tree/feature/flare-iam https://github.com/liramon1/language-servers/tree/liramon/flare-iam Current PR built upon flare-mega branch and is working to merge with flare-mega branch. This PR fails a web test that flare-mega branch is also failing, at the same place. --- - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
bywang56
pushed a commit
that referenced
this pull request
Aug 4, 2025
… autofill access key id (#7797) ## Problem UI and error message no longer compatible after adding IAM credentials authflow IAM Access Key needs manual input every time a client log in ## Solution This is part of #7507 and is built on top of #7659. --- - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Ramon Li <[email protected]>
…scode into feature/flare-iam
bywang56
pushed a commit
that referenced
this pull request
Aug 6, 2025
## Problem The webview does not support STS credentials input (sessionToken and roleArn) and endpoint to LSP does not support STS credentials and profiles. ## Solution This is part of #7507 and is built on top of #7797. - Add STS credentials input box webview, enabling mfa verification if credentials has assume role with mfa permission - Modify AuthUtils and auth2.ts to accommodate new IAM profile type - Add stsCache and other sts handlers to connect to LSP --- - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Ramon Li <[email protected]>
9ac2a3d
to
fcc4285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The authentication flow does not make requests to IAM credentials endpoints on Flare and does not provide places for clients to input long-term IAM credentials or STS credentials.
Solution
This feature is split into multiple PRs (in order):
Meanwhile, we are making changes to language-servers and language-server-runtimes such that authentication for IAM credentials can happen on Flare side.
Tests will work with this version of language-server-runtimes:
https://github.com/liramon1/language-server-runtimes/tree/feature/flare-iam
and this version of language-servers:
https://github.com/liramon1/language-servers/tree/liramon/flare-iam
Please reference these when reviewing our work
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.