-
Notifications
You must be signed in to change notification settings - Fork 710
feat(stepfunctions): Supporting Express Executions in Execution Details #7664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laileni-aws
merged 1 commit into
aws:feature/stepfunctions-execution
from
l0minous:ExpressExecutions
Jul 22, 2025
Merged
feat(stepfunctions): Supporting Express Executions in Execution Details #7664
laileni-aws
merged 1 commit into
aws:feature/stepfunctions-execution
from
l0minous:ExpressExecutions
Jul 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zelzhou
suggested changes
Jul 15, 2025
anthonyting
suggested changes
Jul 15, 2025
packages/core/src/stepFunctions/executionDetails/executionDetailProvider.ts
Outdated
Show resolved
Hide resolved
5330f3d
to
9a1617d
Compare
anthonyting
suggested changes
Jul 18, 2025
packages/core/src/stepFunctions/wizards/viewExecutionDetailsWizard.ts
Outdated
Show resolved
Hide resolved
9a1617d
to
fd656bb
Compare
anthonyting
approved these changes
Jul 22, 2025
zelzhou
approved these changes
Jul 22, 2025
bywang56
approved these changes
Jul 22, 2025
laileni-aws
reviewed
Jul 22, 2025
* @param executionArn The ARN of the execution to display | ||
*/ | ||
public async initializePanel(panel: vscode.WebviewPanel, executionArn: string): Promise<void> { | ||
public async initializePanel(panel: vscode.WebviewPanel, executionArn: string, startTime?: string): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Do we have dispose events for this Webview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There arent any currently but maybe later if something that needs to be disposed is added
laileni-aws
approved these changes
Jul 22, 2025
68253c3
into
aws:feature/stepfunctions-execution
34 of 37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
View Execution Details by Execution ARN
command currently only supports Standard ExecutionsSolution
getFunctionConfiguration
(used when viewing executions that have a Lambda state)activation.ts
to differentiate between standard and express executions, express executions prompt for a second input box to pass instartTime
CloudWatchLogsClient
to be used alongside lambda client in ApiHandlerstartTime
through meta tagVerification
feature/x
branches will not be squash-merged at release time.