feat(amazonq): UI Tests Baseline Framework Complete Set Up #7727
Conversation
…as webpack.NormalModuleReplacementPlugin that needed to be there in order for the amazonq to compile
…he checks. have to commit to check since the build compiles with no errors
…e tests are done running
…lkit-vscode into feature/ui-e2e-tests
…s to handle mynah overlays
packages/amazonq/test/e2e_new/amazonq/framework/backslashHelper.ts
Outdated
Show resolved
Hide resolved
|
I recommend reorganizing the files by component that you're testing, for example a pinContext folder that has the test and related helper files in that folder. utilities shared by multiple tests (like generalHelper) can be moved to utils |
laura-codess
changed the title
|
From discussion, if one test fails we likely want some kind of general clean up util to ensure all the others don't. This may just be a reload window command? Might require some experimentation. |
|
Don't see any blockers. I think the clean up can be done as a follow-up since atm I believe one test failing could cause the rest to fail. |
packages/amazonq/test/e2e_new/amazonq/pinContext/pinContextHelper.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/test/e2e_new/amazonq/switchModel/switchModelHelper.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/test/e2e_new/amazonq/pinContext/pinContextHelper.ts
Outdated
Show resolved
Hide resolved
| throw new Error('No selectable login options found') | ||
| } | ||
|
|
||
| const companyItem = await findItemByText(selectableItems, 'Company account') |
There was a problem hiding this comment.
Why not do all of these without the varaiable assignment. Its making it hard to read.
There was a problem hiding this comment.
is this what you're suggesting?
| const companyItem = await findItemByText(selectableItems, 'Company account') | |
| await findItemByText(selectableItems, 'Company account').click(); |
There was a problem hiding this comment.
i think having it in two lines is more readable
There was a problem hiding this comment.
We had an internal discussion. Spaces and comments should do it.
laura-codess
merged commit 97397a8
into
aws:feature/ui-e2e-tests
Change
This is a large PR for all the baseline setup of the framework. It includes the auth, setup, 4 test suites and the abstractions for each, and the cleanup functions.
feature/xbranches will not be squash-merged at release time.