feat: encrypt profile endpoints #650
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awschristou
reviewed
Aug 5, 2025
| @@ -141,7 +141,7 @@ export interface ListProfilesResult { | |||
| // Potential error codes: E_UNKNOWN | E_TIMEOUT | E_RUNTIME_NOT_SUPPORTED | E_CANNOT_READ_SHARED_CONFIG | |||
| export const listProfilesRequestType = new ProtocolRequestType< | |||
| ListProfilesParams, | |||
| ListProfilesResult, | |||
| ListProfilesResult | string, | |||
There was a problem hiding this comment.
Can we avoid having two different types of responses? Clients written in different languages will receive a json blob, and cannot reliably differentiate a structured type from a string.
liramon1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The IAM authentication changes assume that the language server and language client exchange IAM credentials in plaintext through the listProfiles and updateProfile endpoints. Sensitive data, like IAM credentials, should instead be encrypted in-transit to follow best security practices.
Solution
This is part of #572.
This is a breaking change since language clients must decrypt listProfiles responses. Be sure to merge this alongside language-servers and aws-toolkit-vscode.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.