Skip to content

Conversation

@meyertst-aws
Copy link
Contributor

Add exception logging
Remove hard-coded regions
Replace exit with throw
Replace deprecated Thread.sleep
Fix compiler warnings
Run SwiftFormat to format code

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc. labels Sep 19, 2024
@meyertst-aws meyertst-aws self-assigned this Sep 19, 2024
@meyertst-aws meyertst-aws force-pushed the swift_update_iam branch 2 times, most recently from 983d2c8 to a49c06c Compare September 19, 2024 20:29
Copy link
Contributor

@shepazon shepazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Sep 20, 2024
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 20, 2024
@Laren-AWS Laren-AWS merged commit df5a739 into awsdocs:main Sep 23, 2024
14 checks passed
@meyertst-aws meyertst-aws deleted the swift_update_iam branch September 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants