Skip to content

Conversation

@shepazon
Copy link
Contributor

@shepazon shepazon commented Apr 8, 2025

This PR adds the combined scenario example for SNS and SQS. It's roughly based on the C++ implementation.

Before the code examples team reviews, I'm asking the Swift SDK team to look it over.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shepazon shepazon marked this pull request as draft April 8, 2025 19:32
@shepazon shepazon self-assigned this Apr 8, 2025
@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label Apr 8, 2025
@shepazon shepazon added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Apr 8, 2025
Copy link

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style & Swift usage suggestions.

@shepazon shepazon marked this pull request as ready for review April 10, 2025 18:36
@shepazon shepazon requested review from a team and rlhagerm and removed request for a team April 10, 2025 18:36
Added the scenario example for SNS and SQS. This isn't done yet. The existing
filtering code is not correct and needs to come out and be replaced.
@rlhagerm rlhagerm force-pushed the swift-sqs-scenario branch from f555b23 to 6bb1e65 Compare April 17, 2025 15:07
@rlhagerm rlhagerm added the On Call Review complete On call review complete label Apr 17, 2025
@rlhagerm rlhagerm merged commit 614be06 into awsdocs:main Apr 17, 2025
18 of 19 checks passed
@shepazon shepazon deleted the swift-sqs-scenario branch September 9, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants