Skip to content

Python: Fix type annotations in KMS client methods #7520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2025
Merged

Python: Fix type annotations in KMS client methods #7520

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6f8796
Update key_encryption.py
essercodes Jul 12, 2025
f116b29
Merge branch 'main' into patch-1
essercodes Jul 26, 2025
fed1c20
Update key_encryption.py
essercodes Jul 26, 2025
72ee357
Merge branch 'main' into patch-1
essercodes Jul 28, 2025
c0eb0b3
Merge branch 'main' into patch-1
essercodes Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/example_code/kms/key_encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def from_client(cls) -> "KeyEncrypt":
# snippet-end:[python.example_code.kms.KeyEncrypt.decl]

# snippet-start:[python.example_code.kms.Encrypt]
def encrypt(self, key_id: str, text: str) -> str:
def encrypt(self, key_id: str, text: str) -> bytes:
"""
Encrypts text by using the specified key.

Expand Down Expand Up @@ -64,7 +64,7 @@ def encrypt(self, key_id: str, text: str) -> str:
# snippet-end:[python.example_code.kms.Encrypt]

# snippet-start:[python.example_code.kms.Decrypt]
def decrypt(self, key_id: str, cipher_text: str) -> bytes:
def decrypt(self, key_id: str, cipher_text: bytes) -> str:
"""
Decrypts text previously encrypted with a key.

Expand All @@ -75,7 +75,7 @@ def decrypt(self, key_id: str, cipher_text: str) -> bytes:
try:
return self.kms_client.decrypt(KeyId=key_id, CiphertextBlob=cipher_text)[
"Plaintext"
]
].decode()
except ClientError as err:
logger.error(
"Couldn't decrypt your ciphertext. Here's why: %s",
Expand Down