Decode query params for WebSocket APIs #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you @mattmassicotte for having spot and corrected this. |
Contributor
Author
|
Ah. Right. I should have figured that out on my own... |
Collaborator
|
Thank you Matt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIGatewayWebSocketRequest was not decoding url query parameters from event payloads.
Motivation:
API Gateway WebSocket endpoints do support capturing and forwarding query parameters. Probably just omitted because it isn't particularly common.
Modifications:
Added the field. Added a test. Verified against a real system that uses the feature.
Result:
Query parameters for APIGatewayWebSocketRequest will be available to clients.