ci(version-bump): remove branch rename and reinstall dependencies after existing branch checkout

[hopehadfield]

Hey, I just made a Pull Request!

Another followup on #5899 to address this error in running the new version bump workflow on a workspace with an existing version bump PR.

I think the workspace yarn install step can run after the Create or checkout workspace branch, as its just the root dependencies that need to be installed to run the steps between this and the setup. For simplicity sake while this new workflow is still being tested, though, I thought it best to leave the order as is and re-run it for this single use case. Once this is confirmed to work I think it'll would be good to clean this file up and extract a couple of the longer steps into their own JavaScript files.

Additionally, I discovered that when you rename a branch, GitHub closes all pull requests from that branch, which obviously is not desired behaviour. This PR also removes that change from the workflow.

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[hopehadfield]

@awanlin I know you voiced some concern over the branch name not matching the current version. The other option I can think of is to instead push both the old version bump commit(s) (to retain history) and newest version bump commit to a new PR and allow the old one to close, but I don't know if that serves the purpose of reducing PR noise very well.

I don't see as much friction with leaving the branch name as is, but then again I don't personally use the branch to determine what version the update corresponds to. Not sure if you have any more thoughts on the tradeoff here, but happy to take feedback.

[vinzscam]

Additionally, I discovered that when you rename a branch, GitHub closes all pull requests from that branch, which obviously is not desired behaviour. This PR also removes that change from the workflow.

Will there be any open PR from the old branch?

[hopehadfield]

Will there be any open PR from the old branch?

Yes, the open PR (and only PR this workflow touches) will remain on a branch with the old version number. Initially, the new version bump commit was added to the old version bump PR, and the branch was renamed to match the new version number. Now, the same process is followed but without the branch rename.