Various UI/UX improvements #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
agorer
approved these changes
Oct 7, 2025
packages/lib/modules/pool/PoolDetail/PoolStats/PoolSnapshot/UserSnapshotValues.tsx
Outdated
Show resolved
Hide resolved
| <PopoverContent p="sm"> | ||
| <Text fontSize="sm" variant="secondary"> | ||
| Target weights are only applicable to tokens within Weighted Pools. | ||
| There is no concept of a target weight for tokens within{' '} |
There was a problem hiding this comment.
Should we just remove the target weights when not applicable?
There was a problem hiding this comment.
I don't have a strong opinion on this but I prefer to show it and provide an explanation. Mostly because most people are conditioned to 50/50 weighted pools across DeFi. So when they encounter a pool like this where the composition is not 50% / 50%, they may get worried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots: