Skip to content

Conversation

gkurts
Copy link

@gkurts gkurts commented Sep 4, 2025

(closed original #1413 and opened this one to target from and to dev branch)

Adds support for showing the current theme's wallpaper on the lock screen.

This change adds a 'path = $background' entry to the hyprlock.conf file.

The theme must add a '$background = ~/.config/omarchy/current/background' line to the hyprlock.conf file in the theme folder for this to work.

If $background is not set, hyprlock simply ignores the line.

@gkurts
Copy link
Author

gkurts commented Sep 7, 2025

Link to bug #1488

@dhh
Copy link
Member

dhh commented Sep 7, 2025

This will need a migration to add it to existing hyprlock.conf files. Use grep + sed so we don't have to refresh the whole file 👌

@gkurts
Copy link
Author

gkurts commented Sep 7, 2025

Got chya. I'll get that added to this PR this evening.

@gkurts
Copy link
Author

gkurts commented Sep 7, 2025

Added migration, but to be clear, adding this line to the hyprlock.conf will not trigger the wallpaper to show on the lock screen.

The theme must add the $background = ~/.config/omarchy/current/background value into its hyprlock.conf file. I can do that as a migration for all default themes or simply leave it as an exercise for the end user and/or theme designers.

@dhh
Copy link
Member

dhh commented Sep 8, 2025

I like leaving it for the theme designers. Don't want the default themes to use this, but happy to let extra themes go to town!

@mrpbennett
Copy link

Just for my learning can you explain the use of:

The theme must add a '$background = ~/.config/omarchy/current/background' line to the hyprlock.conf file in the theme folder for this to work.

In my hyprlock file I only have the following and it changes for all themes and all wallpapers.

background {
    monitor =
    path = $HOME/.config/omarchy/current/background
    ...

Just curious on the variable use.

@D-Pagey
Copy link

D-Pagey commented Sep 10, 2025

In my hyprlock file I only have the following and it changes for all themes and all wallpapers.

background {
    monitor =
    path = $HOME/.config/omarchy/current/background
    ...

I added blur_passes = 1 to this and it is 👌

@gkurts
Copy link
Author

gkurts commented Sep 10, 2025

Sure! If the theme designer desides to apply a different wallpaper for the lock screen or something like that, they can do it by specifying $background = $HOME/.config/omarchy/current/<path-to-desired-background. This way, the omarchy hyprlock.conf will respect whatever path the theme designer gives them. Although they will probably just use the standard $HOME/.config/omarchy/current/background symlink, they have that choice.

I really only even went down this path to set the lock screen wallpaper because my daughter likes seeing the omarchy-all-hallows-eve background. 😄

Going to have to check out blur_passes!!

@mrpbennett
Copy link

Sure! If the theme designer desides to apply a different wallpaper for the lock screen or something like that, they can do it by specifying $background = $HOME/.config/omarchy/current/<path-to-desired-background. This way, the omarchy hyprlock.conf will respect whatever path the theme designer gives them. Although they will probably just use the standard $HOME/.config/omarchy/current/background symlink, they have that choice.

I really only even went down this path to set the lock screen wallpaper because my daughter likes seeing the omarchy-all-hallows-eve background. 😄

Going to have to check out blur_passes!!

Got you!! That makes sense now. Thanks for clarifying 

@dhh
Copy link
Member

dhh commented Sep 14, 2025

I don't think this actually works, because often you need to run other background config changes like blur passes, but after playing around with this enough, I got convinced that we should just use the current background and a few blur passes. So that seems like what this was aiming for anyway 😄

@dhh dhh closed this Sep 14, 2025
@gkurts
Copy link
Author

gkurts commented Sep 14, 2025

Got chya! I do like the simpler is better approach. Thanks for the explanation on the decision!

@D-Pagey
Copy link

D-Pagey commented Sep 17, 2025

@mrpbennett our suggestion made it into Omarchy v3 😁

@mrpbennett
Copy link

@mrpbennett our suggestion made it into Omarchy v3 😁

Well now I guess I can say I contributed to Omarchy! 😂😂😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants