-
Notifications
You must be signed in to change notification settings - Fork 1k
Support for wallpapers in hyprlock #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Link to bug #1488 |
This will need a migration to add it to existing hyprlock.conf files. Use grep + sed so we don't have to refresh the whole file 👌 |
Got chya. I'll get that added to this PR this evening. |
Added migration, but to be clear, adding this line to the hyprlock.conf will not trigger the wallpaper to show on the lock screen. The theme must add the |
I like leaving it for the theme designers. Don't want the default themes to use this, but happy to let extra themes go to town! |
Just for my learning can you explain the use of:
In my hyprlock file I only have the following and it changes for all themes and all wallpapers.
Just curious on the variable use. |
I added |
Sure! If the theme designer desides to apply a different wallpaper for the lock screen or something like that, they can do it by specifying $background = $HOME/.config/omarchy/current/<path-to-desired-background. This way, the omarchy hyprlock.conf will respect whatever path the theme designer gives them. Although they will probably just use the standard $HOME/.config/omarchy/current/background symlink, they have that choice. I really only even went down this path to set the lock screen wallpaper because my daughter likes seeing the omarchy-all-hallows-eve background. 😄 Going to have to check out blur_passes!! |
Got you!! That makes sense now. Thanks for clarifying  |
I don't think this actually works, because often you need to run other background config changes like blur passes, but after playing around with this enough, I got convinced that we should just use the current background and a few blur passes. So that seems like what this was aiming for anyway 😄 |
Got chya! I do like the simpler is better approach. Thanks for the explanation on the decision! |
@mrpbennett our suggestion made it into Omarchy v3 😁 |
Well now I guess I can say I contributed to Omarchy! 😂😂😂 |
(closed original #1413 and opened this one to target from and to dev branch)
Adds support for showing the current theme's wallpaper on the lock screen.
This change adds a 'path = $background' entry to the hyprlock.conf file.
The theme must add a '$background = ~/.config/omarchy/current/background' line to the hyprlock.conf file in the theme folder for this to work.
If $background is not set, hyprlock simply ignores the line.