feat: Notification settings persist across theme changes #1484
Conversation
|
@pipetogrep This is nice to clean up some of those common elements. Looks like we just need a migration for this one though if you don't mind adding that. |
|
I can't believe I missed this! I had it in my head that mako didn't have includes? Or maybe it was AI that put that there! |
|
Given that we can do this, I think we should actually put all of this inside Omarchy. The |
|
I've tested this locally and ran the migration to simulate an upgrade, everything seems ok. Would appreciate further testing :) My test involves seeing if my addition of silencing Plexamp notifications in Useful commands: |
migrations/1756371866.sh
Outdated
| @@ -0,0 +1,3 @@ | |||
| echo "Reload notifications" | |||
| cp ~/.local/share/omarchy/default/mako/core.ini ~/.config/mako/ | |||
There was a problem hiding this comment.
I don't think this is right? We are not supposed to copy the core. Only the current theme one.
There was a problem hiding this comment.
Actually, don't even need to copy current theme. That's already in the right place.
Mako is already loaded. The new config will get picked up automatically on next reboot.
* Added a core.ini file for setting persistent notification settings * migration * remove: max-icon-size from core.ini * rearranging mako files * moving core.ini mako config inside omarchy * added core.ini to migration * We don't actually need this Mako is already loaded. The new config will get picked up automatically on next reboot. * Don't change * No change required here --------- Co-authored-by: robert stringer <[email protected]> Co-authored-by: xz <xz> Co-authored-by: David Heinemeier Hansson <[email protected]>
* Added a core.ini file for setting persistent notification settings * migration * remove: max-icon-size from core.ini * rearranging mako files * moving core.ini mako config inside omarchy * added core.ini to migration * We don't actually need this Mako is already loaded. The new config will get picked up automatically on next reboot. * Don't change * No change required here --------- Co-authored-by: robert stringer <[email protected]> Co-authored-by: xz <xz> Co-authored-by: David Heinemeier Hansson <[email protected]>
* Added a core.ini file for setting persistent notification settings * migration * remove: max-icon-size from core.ini * rearranging mako files * moving core.ini mako config inside omarchy * added core.ini to migration * We don't actually need this Mako is already loaded. The new config will get picked up automatically on next reboot. * Don't change * No change required here --------- Co-authored-by: robert stringer <[email protected]> Co-authored-by: xz <xz> Co-authored-by: David Heinemeier Hansson <[email protected]>
* Added a core.ini file for setting persistent notification settings * migration * remove: max-icon-size from core.ini * rearranging mako files * moving core.ini mako config inside omarchy * added core.ini to migration * We don't actually need this Mako is already loaded. The new config will get picked up automatically on next reboot. * Don't change * No change required here --------- Co-authored-by: robert stringer <[email protected]> Co-authored-by: xz <xz> Co-authored-by: David Heinemeier Hansson <[email protected]>
This PR separates the theme values from common settings in each theme's
mako.ini.Common values are set in
~/config/mako/core.iniand then included per theme.The main motivation for this was having a central location to set app specific mako preferences, and having them persist when changing themes.