Skip to content

Conversation

@patroza
Copy link
Contributor

@patroza patroza commented Nov 13, 2025

enables targeting terminal apps specifically for windowrule and -launch-or-focus similar to Wiremix.

@patroza patroza changed the base branch from master to dev November 13, 2025 13:43
@dhh
Copy link
Member

dhh commented Nov 17, 2025

What purpose does this serve? We don't identify it when starting it via the default bindings either.

@patroza
Copy link
Contributor Author

patroza commented Nov 17, 2025

What purpose does this serve? We don't identify it when starting it via the default bindings either.

enables targeting btop app specifically for windowrule and -launch-or-focus similar to Wiremix.
from my pov, all terminal apps should actually be targetable individually.

The motiviation is e.g trying to launch-or-focus another terminal window will instead focus the running btop "app"

@dhh
Copy link
Member

dhh commented Nov 17, 2025

Need to do this consistently, then, in all the places where btop is invoked. Including bindings. And need migrations to get it all sorted for everyone.

@patroza
Copy link
Contributor Author

patroza commented Nov 17, 2025

Need to do this consistently, then, in all the places where btop is invoked. Including bindings. And need migrations to get it all sorted for everyone.

Sure. It's added to bindings and waybar, and added migrations.
update also added for the remaining; lazydocker and terminal editors.

@patroza patroza force-pushed the f/uniquely-identify-btop branch 2 times, most recently from 5aeb29d to 40c3a70 Compare November 17, 2025 13:41
@patroza patroza changed the title improve: uniquely identify btop when launched from waybar improve: uniquely identify terminal apps for window rules and focus Nov 17, 2025
@patroza patroza force-pushed the f/uniquely-identify-btop branch from 489e646 to 6556335 Compare November 17, 2025 13:51
@patroza patroza marked this pull request as draft November 17, 2025 14:00
@patroza
Copy link
Contributor Author

patroza commented Nov 17, 2025

I have a better idea, one sec

@patroza patroza marked this pull request as ready for review November 17, 2025 14:14
@patroza patroza force-pushed the f/uniquely-identify-btop branch from b1d33a6 to 5dd3456 Compare November 18, 2025 10:14
@patroza patroza changed the title improve: uniquely identify terminal apps for window rules and focus improve: uniquely identify terminal apps for window rules and focus. Unify waybar behaviour to use launch-or-focus Nov 18, 2025
@dhh dhh merged commit eec075b into basecamp:dev Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants