Catch exceptions thrown by the connected callback #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A failure to call the connected callback should not be treated as a failure to establish a connection. The 'riak_core_connection' process should catch any exceptions thrown by this callback and exit normally.
|
Compilation error. Unsure why it's happening as the syntax looks fine but needs to be investigated. |
nickelization
force-pushed
the
develop
branch
from
a8fbe0c to
a8682dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A failure to call the connected callback should not be treated as a
failure to establish a connection. The 'riak_core_connection' process
should catch any exceptions thrown by this callback and exit normally.
Addresses issue #723 (RIAK-1671) (RIAK-2379).