Skip to content

fix(pypi): pull fewer wheels with experimental_index_url #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(pypi): pull fewer wheels with experimental_index_url #3058

wants to merge 5 commits into from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jul 5, 2025 •
edited
Loading

DO NOT MERGE: stacked on #3112.

Before this we would pull all of the wheels that the user target configuration
would be compatible with and that meant that it was not customizable. This also
meant that there were a lot of footguns in the configuration where the select
statements were not really foolproof.

With this PR we select only those sources that need to be for the declared
configurations.

Freethreaded support should be done by defining extra freethreaded platforms
using the new builder API. It is done as a followup in #3063.

This is also changing the default platforms to be only the fully supported
platforms. This makes the testing easier and avoids us running into
compatibility issues during the rollout.

Work towards #2747
Fixes #2759
Fixes #2849

@aignas aignas force-pushed the exp/pypi-simplify branch from 1d55c50 to c95dce6 Compare July 5, 2025 03:21
@aignas
Copy link
Collaborator Author

aignas commented Jul 5, 2025 •
edited
Loading

Created this as WIP to signal that I am working on this and to invite feedback. The CI should be mostly happy but there are a few TODOs before we can fully merge and I want to test it a little bit more.

  • Freethreaded platform definition should be possible.
  • Probably something else that I need to think of more carefully.

TODO cleanup after this PR is proven to not break things:

@aignas aignas changed the title next: pypi stabilization of experimental_index_url fix(pypi): pull fewer wheels with experimental_index_url Jul 5, 2025
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
ce4dd59 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
@aignas aignas mentioned this pull request Jul 6, 2025
Draft
@aignas
Copy link
Collaborator Author

aignas commented Jul 6, 2025

The CI failure is a flake.

@aignas aignas force-pushed the exp/pypi-simplify branch 2 times, most recently from dc50a12 to 855a673 Compare July 6, 2025 13:42
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
68dfedb 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
@aignas
Copy link
Collaborator Author

aignas commented Jul 6, 2025

This would be ready to be reviewed, but because it is stacked on two PRs, let's get those out of the way first.

aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
5a1d250 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
73c74d9 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
bc8424b 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
feat: freethreaded support for the builder API
5e66b5b 
Stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747

TODO:
- [ ] Fix the remaining expectations in the unit tests. Maybe make the
  tests less brittle and define platforms for unit testing.
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
chore(pypi): remove unused config setting code
0f203ba 
Stacked on bazel-contrib#3058

Since the parent PR is simplifying the code a great deal, we can remove
the unused code and its tests. Hopefully this makes the whole codebase
easier to contribute to. There is probably more cleanup that can be
done, but since the CI is now green, it's a good start.
@aignas aignas mentioned this pull request Jul 6, 2025
Draft
aignas added a commit to aignas/rules_python that referenced this pull request Jul 6, 2025
@aignas
chore(pypi): remove unused config setting code
3141590 
Stacked on bazel-contrib#3058

Since the parent PR is simplifying the code a great deal, we can remove
the unused code and its tests. Hopefully this makes the whole codebase
easier to contribute to. There is probably more cleanup that can be
done, but since the CI is now green, it's a good start.
rickeylev
rickeylev reviewed Jul 6, 2025
View reviewed changes
@aignas aignas marked this pull request as ready for review July 7, 2025 13:15
@aignas aignas requested a review from groodt as a code owner July 7, 2025 13:15
This was referenced Jul 7, 2025
Open
Open
@keith
Copy link
Member

keith commented Jul 7, 2025 •
edited
Loading

I hit this problem with this change (I don't support windows and use requirements_by_platform to exclude it too):

% bazel query 'deps(...)'
INFO: Repository rules_python++python+python_3_13_aarch64-pc-windows-msvc instantiated at:
  <builtin>: in <toplevel>
Repository rule python_repository defined at:
  /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl:271:36: in <toplevel>
ERROR: /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl:76:34: An error occurred during the fetch of repository 'rules_python++python+python_3_13_aarch64-pc-windows-msvc':
   Traceback (most recent call last):
        File "/home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl", line 76, column 34, in _python_repository_impl
                rctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error extracting /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862/cpython-3.13.5+20250702-aarch64-pc-windows-msvc-install_only.tar.gz to /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862: Prefix "python/install" was given, but not found in the archive. Here are possible prefixes for this archive: "python".
ERROR: Evaluation of query "deps(...)" failed: preloading transitive closure failed: no such package '@@rules_python++python+python_3_13_aarch64-pc-windows-msvc//': java.io.IOException: Error extracting /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862/cpython-3.13.5+20250702-aarch64-pc-windows-msvc-install_only.tar.gz to /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862: Prefix "python/install" was given, but not found in the archive. Here are possible prefixes for this archive: "python".
Loading: 2635 packages loaded

@aignas
Copy link
Collaborator Author

aignas commented Jul 7, 2025 •
edited
Loading

Thank you, I'll take a look later.

Marking this as a draft for now.

@aignas aignas marked this pull request as draft July 7, 2025 23:50
@aignas aignas marked this pull request as ready for review July 8, 2025 04:09
@aignas
Copy link
Collaborator Author

aignas commented Jul 8, 2025

I hit this problem with this change (I don't support windows and use requirements_by_platform to exclude it too):

% bazel query 'deps(...)'
INFO: Repository rules_python++python+python_3_13_aarch64-pc-windows-msvc instantiated at:
  <builtin>: in <toplevel>
Repository rule python_repository defined at:
  /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl:271:36: in <toplevel>
ERROR: /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl:76:34: An error occurred during the fetch of repository 'rules_python++python+python_3_13_aarch64-pc-windows-msvc':
   Traceback (most recent call last):
        File "/home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python+/python/private/python_repository.bzl", line 76, column 34, in _python_repository_impl
                rctx.download_and_extract(
Error in download_and_extract: java.io.IOException: Error extracting /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862/cpython-3.13.5+20250702-aarch64-pc-windows-msvc-install_only.tar.gz to /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862: Prefix "python/install" was given, but not found in the archive. Here are possible prefixes for this archive: "python".
ERROR: Evaluation of query "deps(...)" failed: preloading transitive closure failed: no such package '@@rules_python++python+python_3_13_aarch64-pc-windows-msvc//': java.io.IOException: Error extracting /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862/cpython-3.13.5+20250702-aarch64-pc-windows-msvc-install_only.tar.gz to /home/ubuntu/.cache/bazel/_bazel_ubuntu/480ee760ab026be301955dc1adc19e40/external/rules_python++python+python_3_13_aarch64-pc-windows-msvc/temp6334258738180209862: Prefix "python/install" was given, but not found in the archive. Here are possible prefixes for this archive: "python".
Loading: 2635 packages loaded

@keith, #3070 should fix your issue, I think. The toolchain pulling in query seems to be unrelated to pip integration, so if it works after #3070 and #3058 is merged, I think it is safe to say that the issue is resolved.

@aignas aignas mentioned this pull request Jul 8, 2025
Open
hartikainen
hartikainen reviewed Jul 8, 2025
View reviewed changes
@aignas aignas requested a review from hartikainen July 12, 2025 14:19
@aignas aignas mentioned this pull request Aug 2, 2025
Open
aignas added a commit to aignas/rules_python that referenced this pull request Aug 3, 2025
@aignas
feat(pypi): incrementally build platform configuration
d547f24 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 3, 2025
@aignas
fix(pypi): reuse select dicts for constructing the env
66ec7bc 
Before this PR we would be constructing slightly different environments
when the `env_marker_setting` is doing it in the analysis phase and when
we are doing it in the repo phase due to how the defaults are handled.

In this change we simply reuse the same select statements and add an extra
helper that is allowing us to process that.

Work towards bazel-contrib#2949
Prep for bazel-contrib#3058
aignas added a commit to aignas/rules_python that referenced this pull request Aug 3, 2025
@aignas
feat(pypi): add a standards compliant python_tag creator
381402b 
This will be needed when we start selecting wheels entirely in the
bzlmod extension evaluation phase (bazel-contrib#3058).

This adds a few unit tests to just ensure that we conform to the spec
even though the code is very simple.

Work towards bazel-contrib#2747
Work towards bazel-contrib#2759
Work towards bazel-contrib#2849
aignas added a commit to aignas/rules_python that referenced this pull request Aug 3, 2025
@aignas
feat(pypi): incrementally build platform configuration
16fe508 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
@aignas aignas force-pushed the exp/pypi-simplify branch from 89e58de to 891af92 Compare August 3, 2025 05:34
aignas added a commit to aignas/rules_python that referenced this pull request Aug 3, 2025
@aignas
feat(pypi): freethreaded support for the builder API
5fd3c86 
DO NOT MERGE: stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747
hartikainen pushed a commit to hartikainen/rules_python that referenced this pull request Aug 3, 2025
@aignas @hartikainen
feat(pypi): freethreaded support for the builder API
63b5791 
DO NOT MERGE: stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): incrementally build platform configuration
2b56f94 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
aignas added 3 commits August 9, 2025 21:19
@aignas
fix(pypi): reuse select dicts for constructing the env
6f3dab1 
Before this PR we would be constructing slightly different environments
when the `env_marker_setting` is doing it in the analysis phase and when
we are doing it in the repo phase due to how the defaults are handled.

In this change we simply reuse the same select statements and add an extra
helper that is allowing us to process that.

Work towards bazel-contrib#2949
Prep for bazel-contrib#3058
@aignas
feat(pypi): add a standards compliant python_tag creator
31967c5 
This will be needed when we start selecting wheels entirely in the
bzlmod extension evaluation phase (bazel-contrib#3058).

This adds a few unit tests to just ensure that we conform to the spec
even though the code is very simple.

Work towards bazel-contrib#2747
Work towards bazel-contrib#2759
Work towards bazel-contrib#2849
@aignas
feat(pypi): implement a new whl selection algorithm
9792058 
DO NOT MERGE: stacked on bazel-contrib#3110

This PR only implements the selection algorithm where instead of
selecting all wheels that are compatible with the set of target
platforms, we select a single wheel that is most specialized for a
particular *single* target platform.

What is more, compared to the existing algorithm it does not assume
a particular list of supported platforms and just fully implements the
spec.

Work towards bazel-contrib#2747
Work towards bazel-contrib#2759
Work towards bazel-contrib#2849
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): incrementally build platform configuration
0354257 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
@aignas aignas force-pushed the exp/pypi-simplify branch from 891af92 to 0b8596d Compare August 9, 2025 12:21
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): freethreaded support for the builder API
66c133d 
DO NOT MERGE: stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747
@aignas aignas marked this pull request as draft August 9, 2025 13:45
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): freethreaded support for the builder API
e9331ae 
DO NOT MERGE: stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): incrementally build platform configuration
7816c21 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 9, 2025
@aignas
feat(pypi): incrementally build platform configuration
06ab934 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 10, 2025
@aignas
feat(pypi): incrementally build platform configuration
47539df 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
aignas added a commit to aignas/rules_python that referenced this pull request Aug 10, 2025
@aignas
feat(pypi): incrementally build platform configuration
d5075c3 
Before this PR the configuration for platforms would be built
non-incrementally, making it harder for users to override particular
attributes of the already configured ones.

With this PR the new features introduced in bazel-contrib#3058 will be easier to
override.

Work towards bazel-contrib#2747
@aignas aignas force-pushed the exp/pypi-simplify branch from 0b8596d to c757256 Compare August 10, 2025 14:57
aignas added 2 commits August 11, 2025 00:07
@aignas
feat(pypi): incrementally build platform configuration
7d36af2 
Before this PR the configuration for platforms would be built
non-incrementally and was somewhat special, making it harder to override
particular attributes of the already configured ones.
@aignas
fix(pypi): pull fewer wheels with experimental_index_url
e2d2dd0 
Before this we would pull all of the wheels that the user target
configuration would be compatible with and that meant that it was not
customizable. This also meant that there were a lot of footguns in the
configuration where the select statements were not really foolproof.

With this PR we select only those sources that need to be for the
declared configurations.

Freethreaded support is done by defining extra freethreaded platforms
using the new builder API (bazel-contrib#3063).

This is also changing the default platforms to be only the fully supported
platforms. This makes the testing easier and avoids us running into
compatibility issues during the roll out.

Work towards bazel-contrib#2747
Fixes bazel-contrib#2759
Fixes bazel-contrib#2849
@aignas aignas force-pushed the exp/pypi-simplify branch from c757256 to e2d2dd0 Compare August 10, 2025 15:11
aignas added a commit to aignas/rules_python that referenced this pull request Aug 10, 2025
@aignas
feat(pypi): freethreaded support for the builder API
040f77e 
DO NOT MERGE: stacked on bazel-contrib#3058

This is a continuation of bazel-contrib#3058 where we define freethreaded
platforms. They need to be used only for particular python versions
so I included an extra marker configuration attribute where we
are using pipstar marker evaluation before using the platform.

I think this in general will be a useful tool to configure only
particular platforms for particular python versions

Work towards bazel-contrib#2548, since this shows how we can define custom platforms
Work towards bazel-contrib#2747
github-merge-queue bot pushed a commit that referenced this pull request Aug 11, 2025
@aignas @rickeylev
fix(pypi): reuse select dicts for constructing the env (#3108)
5c09732 
Before this PR we would be constructing slightly different environments
when the `env_marker_setting` is doing it in the analysis phase and when
we are doing it in the repo phase due to how the defaults are handled.

In this change we simply reuse the same select statements and add an
extra
helper that is allowing us to process that.

Work towards #2949
Prep for #3058

Co-authored-by: Richard Levasseur <[email protected]>
aignas added a commit to aignas/rules_python that referenced this pull request Aug 11, 2025
@aignas
feat(pypi): add a standards compliant python_tag creator
343da20 
This will be needed when we start selecting wheels entirely in the
bzlmod extension evaluation phase (bazel-contrib#3058).

This adds a few unit tests to just ensure that we conform to the spec
even though the code is very simple.

Work towards bazel-contrib#2747
Work towards bazel-contrib#2759
Work towards bazel-contrib#2849
github-merge-queue bot pushed a commit that referenced this pull request Aug 11, 2025
@aignas
feat(pypi): add a standards compliant python_tag creator (#3110)
df44566 
This will be needed when we start selecting wheels entirely in the
bzlmod extension evaluation phase (#3058).

This adds a few unit tests to just ensure that we conform to the spec
even though the code is very simple.

Work towards #2747
Work towards #2759
Work towards #2849
github-merge-queue bot pushed a commit that referenced this pull request Aug 11, 2025
@aignas
feat(pypi): add a standards compliant python_tag creator (#3110)
a36d002 
This will be needed when we start selecting wheels entirely in the
bzlmod extension evaluation phase (#3058).

This adds a few unit tests to just ensure that we conform to the spec
even though the code is very simple.

Work towards #2747
Work towards #2759
Work towards #2849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt Awaiting requested review from groodt groodt is a code owner

@hartikainen hartikainen Awaiting requested review from hartikainen

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type: pip pip/pypi integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimental_index_url slows down downloads by 25-50% "Illegal ambiguous match" error with experimental_index_url
4 participants
@aignas @keith @hartikainen @rickeylev