fix(pypi): support properly installing sdists via pypi without index #3115
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
force-pushed
the
fix.requirement.line
branch
2 times, most recently
from
3a1189f to
75871bb
Compare
This fixes the subtle bug introduced in bazel-contrib#2871, where we were dropping the URL from the requirement, because we can download the sdist directly. We cannot add `--no-index` because sdists in general may require extra build dependencies and we had already issues previously (see 0.36 release notes). Fixes bazel-contrib#2363
aignas
force-pushed
the
fix.requirement.line
branch
from
75871bb to
69b06d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the subtle bug introduced in #2871, where we were dropping
the URL from the requirement, because we can download the sdist
directly. We cannot add --no-index because sdists in general may
require extra build dependencies and we had already issues previously
(see 0.36 release notes).
Fixes #2363
Fixes #3131