Skip to content

docs(toolchains): set dev_dependency=True on repo rule invocation #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025

Conversation

honglooker
Copy link
Contributor

@honglooker honglooker commented Jul 30, 2025

Move dev_dependency = True to the repo rule invocation. The use_repo_rule call
doesn't support that arg.

Remove `dev_dependency = True` for use_repo_rule invocations - invalid kwarg
aignas
aignas previously requested changes Aug 1, 2025
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what the bazel docs say here

@honglooker
Copy link
Contributor Author

@aignas
Copy link
Collaborator

aignas commented Aug 5, 2025

@meteorcloudy, could you please clarify if this is a bug in bazel or bazel docs?

@meteorcloudy
Copy link
Contributor

meteorcloudy commented Aug 11, 2025

The repo_rule_proxy belongs to the repo rule proxy not use_repo_rule directive. So the correct usage is

local_runtime_repo(
    name = "local_python3",
    interpreter_path = "python3",
    on_failure = "fail",
    dev_dependency = True,
)

I can see how the doc might be confusing, happy to help review a PR to help clarify this!

/cc @Wyverald

@rickeylev rickeylev changed the title docs: update toolchains.md docs(toolchains): set dev_dependency=True on repo rule invocation Aug 11, 2025
@rickeylev rickeylev dismissed aignas’s stale review August 11, 2025 16:05

problem addressed

@rickeylev rickeylev enabled auto-merge August 11, 2025 16:06
@rickeylev rickeylev added this pull request to the merge queue Aug 11, 2025
Merged via the queue into bazel-contrib:main with commit 6038ac4 Aug 11, 2025
3 checks passed
@rickeylev
Copy link
Collaborator

Thanks for fixing the docs @honglooker!

@honglooker
Copy link
Contributor Author

np :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants