Add support for net-http2 backend#804
Open
singpolyma-shopify wants to merge 1 commit intobblimke:masterfrom
Open
Add support for net-http2 backend#804singpolyma-shopify wants to merge 1 commit intobblimke:masterfrom
singpolyma-shopify wants to merge 1 commit intobblimke:masterfrom
Conversation
Owner
|
@singpolyma-shopify Thank you! Do you plan to add specs and cover real requests? |
Author
|
@bblimke I'd like to. I worked on this a bit just now, but I think the test server for testing "real" requests might not support http/2, which make re-using the existing acceptance tests a bit tricky. |
Owner
|
@singpolyma-shopify right, that would probably require a new set of tests. |
3aa1f1d to
d153044
Compare
d153044 to
d49a413
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.