Start connection in Net::HTTP adapter for mocked requests#960
Open
ojab wants to merge 1 commit intobblimke:masterfrom
Open
Start connection in Net::HTTP adapter for mocked requests#960ojab wants to merge 1 commit intobblimke:masterfrom
Net::HTTP adapter for mocked requests#960ojab wants to merge 1 commit intobblimke:masterfrom
Conversation
Instrumentation like Sentry only instruments requests when `Net::HTTP.started?` because `#request` is called twice if connection is not started yet. This change allows this instrumentation to work with mocked requests. See https://github.com/ruby/net-http/blob/master/lib/net/http.rb#L1529-L1534
Contributor
Author
|
Ready to review because CI waits for approval, |
Owner
|
@ojab I'm sorry for the delay. Is that related specifically to Sentry which checks for |
Contributor
Author
|
Sentry prompted me to look into that and I didn't saw any issues about it in other places, but overall it should make mocking more correct and shouldn't bring much overhead. |
Contributor
|
#992 also fixes this, if I'm not mistaken. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrumentation like Sentry only instruments requests when
Net::HTTP.started?because#requestis called twice if connectionis not started yet. This change allows this instrumentation to work
with mocked requests.
See https://github.com/ruby/net-http/blob/master/lib/net/http.rb#L1529-L1534