Skip to content

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 29, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded GitHub Actions to new major versions across CI, release, deploy-preview, nightly, translations, and related workflows (checkout, setup-node, setup-java, download-artifact, Crowdin).
    • Bumped project Node version requirement and runtime config to Node 22.
    • Updated a dependency resolution for libxmljs2 to a newer patch.
    • No workflow logic, commands, or artifact handling were changed.

Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updated GitHub Actions workflows to newer action versions (checkout, download-artifact, setup-node, setup-java, crowdin), bumped Node.js across project files (.nvmrc and package.json engines) and updated a libxmljs2 resolution in package.json. No runtime logic or workflow control flow changes.

Changes

Cohort / File(s) Summary
Checkout v5 migration
.github/workflows/auto-close.yml, .../build-release.yml, .../ci.yml, .../deploy-preview.yml, .../translations-pr.yml, .../translations-upload.yml
Bumped actions/checkout from v4 to v5.
Download artifact v5 migration
.github/workflows/build-release.yml, .../deploy-preview.yml, .../nightly.yml, .../release.yml
Bumped actions/download-artifact from v4 to v5.
Setup Node v5 migration
.github/workflows/ci.yml, .../deploy-preview.yml
Bumped actions/setup-node from v4 to v5.
Setup Java v5 migration
.github/workflows/ci.yml
Bumped actions/setup-java from v4 to v5.
Crowdin action v2 migration
.github/workflows/translations-pr.yml, .../translations-upload.yml
Bumped crowdin/github-action from v1/1.5.1 to v2.
Node runtime bump
.nvmrc, package.json
Updated Node.js target: .nvmrc 20.19.422.20.0; package.json engines.node 20.x22.x.
Dependency resolution bump
package.json
Updated resolutions.libxmljs2 from 0.32.00.37.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

dependencies

Suggested reviewers

  • KarateBrot
  • nerdCopter
  • VitroidFPV

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request lacks any description and does not include the required template sections outlined in the repository’s guidelines, such as the purpose of the change, how to test it, and references to relevant issues. Without this information, reviewers cannot understand the context or verify that best practices were followed. This omission fails the requirement to provide a clear and structured description. Please add a detailed pull request description using the provided template, including the motivation for the changes, testing instructions, and any relevant issue references, and remove the placeholder template text before merging.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Update github actions” accurately summarizes the primary change in this pull request, which is upgrading GitHub Actions workflows to newer versions. It is concise, clear, and directly reflects the main modifications without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa836ff and 53909eb.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .nvmrc (1 hunks)
  • package.json (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .nvmrc
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-10T18:26:10.136Z
Learnt from: haslinghuis
PR: betaflight/betaflight-configurator#4601
File: package.json:125-125
Timestamp: 2025-09-10T18:26:10.136Z
Learning: The betaflight-configurator project uses Node 20.19.4, which satisfies Vite 7's minimum Node requirement of 20.19+.

Applied to files:

  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: deploy
🔇 Additional comments (2)
package.json (2)

41-41: Verify libxmljs2 compatibility & CI node-version updates

  • Confirm [email protected] works on Node 22.x and addresses the intended fixes.
  • Audit all CI/GitHub Actions configs (e.g. actions/setup-node node-version) to ensure they specify Node 22.x (>=22.12).

133-133: Approve libxmljs2 bump to 0.37.0
This resolution enforces [email protected] for all transitive deps (e.g., plugin-error, through2), includes Node 22 support (added in v0.35.0) and has no documented breaking or security issues.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis changed the title Update node version to latest LTS and github actions Update github actions Sep 29, 2025
@haslinghuis haslinghuis added the dependencies Pull requests that update a dependency file label Sep 29, 2025
Copy link

Copy link
Contributor

Preview URL: https://pr4639.betaflight-app.pages.dev

@haslinghuis haslinghuis removed the dependencies Pull requests that update a dependency file label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: App
Development

Successfully merging this pull request may close these issues.

2 participants