Added manual for Power spectral density spectrums chart #559
Conversation
WalkthroughA new documentation guide for "Blackbox Explorer Power spectral density charts" was added, providing detailed explanations and usage instructions. Additionally, two links to this new documentation were inserted into an existing guide under the "Betaflight blackbox explorer Version 3.7" section. No code or public entity changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md (5)
15-18: Improve wording for slider & cursor featuresMinor clarity fixes:
-The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. -The mouse cursor shows current power values by pressing Shift key +Use the vertical “Smooth” slider to adjust curve smoothing – lower smoothing reveals higher frequency resolution. +Hold **Shift** while hovering to read the exact power value at the cursor position.
24-29: Grammar fixes for heat-map settings-It has the next settings by using the three number input fields in the right-up charts corner: -- "Max dBm" - to set maximum power level what is showed as white color at the chart -- "Min dBm" - to set minimum power level what is showed as black color at the chart -- "Limit dBm" - the power values what are less this limit are showed as black +Configure the heat-map with the three numeric fields in the upper-right corner: +• **Max dBm** – power level rendered as pure white +• **Min dBm** – power level rendered as pure black +• **Limit dBm** – values below this threshold are clamped to black
36-36: Spelling: “helpfull” → “helpful”-But the power spectral density by RPM is more helpfull, when the RPM filter works. +The PSD-vs-RPM view is more helpful when the RPM filter is enabled.
42-50: Tighten comparison instructions & fix typos-It possible to compare several spectrums by using of power spectral density spectrum chart. -It possible to compare up to 6 spectrums. +You can compare up to six spectra directly in the PSD chart. -To compare PSD spectrums for one log file curves: -... -- to analyse spectrums difference -- to press "Clr" button to remove the all compared curves -- to repeate Ctr + Mouse click at some curve to remove it from comparison +To compare spectra within the same log: +– Display the “Power spectral density” chart +– Ctrl-click multiple curves in the legend to add them to the comparison +– Analyse the differences +– Click **Clr** to clear all compared curves +– Ctrl-click a highlighted curve to remove it individually
55-59: Export/import section – spelling & flow-... The spectrum data will exported to .CSV file -... what you need for comparison -... the sepctrums will showed at one chart for analyses +... The spectrum data will be exported to a .CSV file. +... you wish to compare. +... All selected spectra will be displayed on a single chart for analysis.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
docs/wiki/guides/current/images/psd_1.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_10.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_2.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_3.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_4.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_5.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_6.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_7.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_8.jpgis excluded by!**/*.jpgdocs/wiki/guides/current/images/psd_9.jpgis excluded by!**/*.jpg
📒 Files selected for processing (2)
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md(1 hunks)docs/wiki/guides/current/Black-Box-logging-and-usage.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md
[grammar] ~27-~27: Ensure spelling is correct
Context: ... chart - "Limit dBm" - the power values what are less this limit are showed as black...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~36-~36: Ensure spelling is correct
Context: ...e power spectral density by RPM is more helpfull, when the RPM filter works. 
[grammar] ~43-~43: Ensure spelling is correct
Context: ...m chart. It possible to compare up to 6 spectrums. To compare PSD spectrums for one log f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: build
🔇 Additional comments (1)
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md (1)
6-10: dB math & spelling corrections
dBm, notdBm/Hz, is a power level; the division by Hz is already implied in power spectral density.- 30 dB represents a power ratio of ×1000 – the doc lists ×100.
- For amplitude (voltage) ratios the factors are √(power ratio); the current description conflates the two.
-The power spectral density charts show the noises level in standard dBm/Hz units. -For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +The charts show noise levels in standard dBm/Hz units. +For example (power ratios): + – a 10 dB increase = ×10 power + – a 20 dB increase = ×100 power + – a 30 dB increase = ×1000 power +(Amplitude ratios are the square-root of these power ratios.)Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (8)
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md (8)
3-3: Grammar/possessive fix
Blackbox Explorers spectrum analyser→Blackbox Explorer’s spectrum analyzer.
Also prefer the common US spelling “analyzer” for consistency with the rest of the docs.
6-10: dBm vs dB and minor wording tweaks
dBmis an absolute power unit; differences should be expressed indB.
Consider tightening the wording:-The power spectral density charts show the noises level in standard dBm/Hz units. -For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +PSD charts display noise levels in standard dBm/Hz. +Rule-of-thumb examples: +* A 10 dB difference equals a 10× change in noise power (20 dB → 100×, 30 dB → 1000×). +* A 20 dB difference equals a 10× change in noise amplitude (40 dB → 100×, 60 dB → 1000×).
15-17: Clarify slider & tooltip description-The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. -The mouse cursor shows current power values by pressing Shift key +Use the vertical slider to adjust curve smoothing; less smoothing yields higher frequency resolution. +Hold Shift while hovering to display the exact power value at the cursor.
24-28: Minor spelling / wording fixes in heat-map settings-It has the next settings by using the three number input fields in the right-up charts corner: -- "Max dBm" - to set maximum power level what is showed as white color at the chart -- "Min dBm" - to set minimum power level what is showed as black color at the chart -- "Limit dBm" - the power values what are less this limit are showed as black +Configure the three numeric fields in the upper-right corner: +* **Max dBm** – power level rendered as pure white +* **Min dBm** – power level rendered as pure black +* **Limit dBm** – values below this threshold are forced to black
35-37: Typo –helpfull→helpfulAlso rephrase for clarity:
-But the power spectral density by RPM is more helpfull, when the RPM filter works. +However, the RPM heat-map is generally more helpful when the RPM filter is active.
42-44: Missing “is” & plural noun-It possible to compare several spectrums by using of power spectral density spectrum chart. -It possible to compare up to 6 spectrums. +It is possible to compare several spectra with the PSD chart—up to six at a time.
49-51: Spelling & shortcut key-- to repeate Ctr + Mouse click at some curve to remove it from comparison +- to repeat Ctrl + Click on a curve legend entry to remove it from comparison
55-59: Multiple typos & passive-voice fix-- to press "Exp" (Export) button. The spectrum data will exported to .CSV file -- to export spectrums from some log files what you need for comparison +Press the **Exp** (Export) button – the spectrum data is saved to a CSV file. +Export spectra from any additional log files you want to compare.-- the sepctrums will showed at one chart for analyses +- all spectra are then rendered on a single chart for analysis
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md(1 hunks)docs/wiki/guides/current/Black-Box-logging-and-usage.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/wiki/guides/current/Black-Box-logging-and-usage.md
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-Power-Specttral-Density-charts.md
[grammar] ~27-~27: Ensure spelling is correct
Context: ... chart - "Limit dBm" - the power values what are less this limit are showed as black...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~36-~36: Ensure spelling is correct
Context: ...e power spectral density by RPM is more helpfull, when the RPM filter works. 
[grammar] ~43-~43: Ensure spelling is correct
Context: ...m chart. It possible to compare up to 6 spectrums. To compare PSD spectrums for one log f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: build
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (8)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (8)
3-3: Fix possessive and terminology in opening sentenceUse the possessive form and pick a single spelling of “analyzer/analyser” for consistency across the docs.
-The Blackbox Explorers spectrum analyser can show power spectral density (PSD) charts +The Blackbox Explorer’s spectrum analyzer can display power spectral density (PSD) charts.
6-10: Clarify wording and correct dB examplesThe current bullets are hard to read and contain small factual/formatting issues.
-The power spectral density charts show the noises level in standard dBm/Hz units. -For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +The PSD charts display noise levels in standard dBm/Hz units. +For example: +* A **10 dB** difference corresponds to a **10×** change in noise power; **20 dB** to **100×**; **30 dB** to **1000×**. +* A **20 dB** difference corresponds to a **10×** change in noise amplitude; **40 dB** to **100×**; **60 dB** to **1000×**.
15-17: Improve explanation of the smoothing slider and Shift-hover-The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. -The mouse cursor shows current power values by pressing Shift key +Use the vertical slider to adjust curve smoothing: less smoothing provides higher frequency resolution. +Hold the **Shift** key while hovering to display the current power value at the cursor position.
24-27: Rephrase heat-map scaling settings and fix grammar-It has the next settings by using the three number input fields in the right-up charts corner: -- "Max dBm" - to set maximum power level what is showed as white color at the chart -- "Min dBm" - to set minimum power level what is showed as black color at the chart -- "Limit dBm" - the power values what are less this limit are showed as black +Configure the heat-map scaling with the three numeric fields in the upper-right corner of the chart: +* **Max dBm** – power level rendered as pure white +* **Min dBm** – power level rendered as pure black +* **Limit dBm** – values below this limit are clamped to black
34-36: Typo (“helpfull”) and smoother wording-It shows the noises power spectral density by frequency and throttle. -It looks like power spectral density by RPM. -But the power spectral density by RPM is more helpfull, when the RPM filter works. +This chart displays noise PSD by frequency and throttle position. +It is visually similar to **PSD vs RPM**, but the RPM-based chart is usually more useful when the RPM filter is enabled.
42-43: Use “spectra” and add missing “is”-It possible to compare several spectrums by using of power spectral density spectrum chart. -It possible to compare up to 6 spectrums. +It is possible to compare multiple spectra using the power spectral density chart (up to six at once).
45-50: Rewrite single-log comparison steps, fix typos & add numbering-To compare PSD spectrums for one log file curves: -- to show "Power spectral density" chart for curve -- to select several curves by Ctrl + Mouse click at the curves legend -- to analyse spectrums difference -- to press "Clr" button to remove the all compared curves -- to repeate Ctr + Mouse click at some curve to remove it from comparison +To compare PSD curves within a single log file: +1. Open the **Power spectral density** chart for any curve. +2. Ctrl-click additional curves in the legend to add them to the comparison (up to six). +3. Inspect the differences between the spectra. +4. Click **Clr** to remove all curves, or Ctrl-click a highlighted curve to remove it individually.
53-59: Rewrite multi-log comparison instructions & correct misspellings-To compare PSD spectrums for different log file curves: -- to show "Power spectral density" for the first log file curve -- to press "Exp" (Export) button. The spectrum data will exported to .CSV file -- to export spectrums from some log files what you need for comparison -- to show "Power spectral density" to compare some curve with other -- to press "Imp" (Import) button. To select several exported curves log files for comparison by using Open file dialog -- the sepctrums will showed at one chart for analyses +To compare spectra from different log files: +1. Open the **Power spectral density** chart for the first log file. +2. Click **Exp** (Export) to save the spectrum to a `.csv` file. +3. Repeat the export step for any additional log files. +4. Open the PSD chart again and click **Imp** (Import), then select the exported `.csv` files. +5. All imported spectra will be displayed on one chart for analysis.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md(1 hunks)docs/wiki/guides/current/Black-Box-logging-and-usage.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/wiki/guides/current/Black-Box-logging-and-usage.md
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md
[style] ~59-~59: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 2664 characters long)
Context: ...s will showed at one chart for analyses 
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: build
|
@coderabbitai - think you missed my comment. Images should go in static/img/blackbox (and update links). Please provide actionable command |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@haslinghuis, let me check the current image locations in the new documentation file and provide the actionable commands to move them to the correct location. 🏁 Script executed: Length of output: 19764 @haslinghuis, I can see the issue now. The images are currently in These commands will:
🐰✨ 🏁 Script executed: Length of output: 2389 @haslinghuis Perfect! ✅ The images have been successfully moved and links updated: Completed Actions:
All images are now properly located in 🐰📁 |
|
Still see some images not supposed to be here - but it was from a previous PR. See 
|
|
@haslinghuis |
|
@demvlad can do here or in a new PR instead. 558 seems ready - just awaiting cool of period |
|
@haslinghuis |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (9)
docs/wiki/guides/current/BBE-MinMax-control-manual.md (1)
5-5: Replace generic image alt-texts with descriptive onesEach
<img>tag uses the generic alt-textimage. Descriptive alt-texts improve accessibility, SEO and Markdown readability.Example fix for one image:
- +Apply the same principle to the other 12 occurrences.
Also applies to: 13-13, 36-36, 42-42, 48-48, 56-56, 66-66, 74-74, 82-82, 90-90, 98-98, 103-103, 115-115
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (8)
6-10: Clarify dBm examples and fix plural / article issuesThe bullets mix singular/plural and omit articles (“values difference”). Suggested wording:
-The power spectral density charts show the noises level in standard dBm/Hz units. -For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +PSD charts show noise levels in standard dBm/Hz units. +For example: +– Every 10 dBm difference corresponds to a ×10 change in noise power (20 dBm → ×100, 30 dBm → ×1000). +– Every 20 dBm difference corresponds to a ×10 change in noise amplitude (40 dBm → ×100, 80 dBm → ×1000).
15-18: Improve sentence flow and grammar-The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. +Use the vertical slider to adjust curve smoothing; lower smoothing gives higher frequency resolution. -The mouse cursor shows current power values by pressing Shift key +Hold the Shift key while hovering to display the current power value.
25-28: Tighten wording & fix “what” → “that”-"Max dBm" - to set maximum power level what is showed as white color at the chart -"Min dBm" - to set minimum power level what is showed as black color at the chart -"Limit dBm" - the power values what are less this limit are showed as black +"Max dBm" – sets the power level rendered as white on the chart. +"Min dBm" – sets the power level rendered as black on the chart. +"Limit dBm" – power values below this limit are also rendered as black.
32-37: Spelling: “helpfull” → “helpful”-But the power spectral density by RPM is more helpfull, when the RPM filter works. +The RPM-based PSD diagram is generally more helpful when the RPM filter is enabled.
42-44: Add missing verb “is” and correct plural-It possible to compare several spectrums by using of power spectral density spectrum chart. -It possible to compare up to 6 spectrums. +It is possible to compare several spectra on the PSD chart—up to six at once.
50-51: Spelling: “repeate” → “repeat”- to repeate Ctr + Mouse click at some curve to remove it from comparison + to repeat Ctrl + click on a curve legend entry to remove it from the comparison
58-60: Fix multiple typos (“sepctrums”, “showed”, “analyses”)- the sepctrums will showed at one chart for analyses + the spectra will be shown on a single chart for analysis
4-64: Use descriptive alt-texts for all imagesEvery image currently uses
![image]. Replace with context-specific descriptions (e.g.,![PSD chart with smoothing slider]). This benefits accessibility and search indexing across 11 instances in this file.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (24)
static/img/blackbox/1.jpgis excluded by!**/*.jpgstatic/img/blackbox/10.jpgis excluded by!**/*.jpgstatic/img/blackbox/11.jpgis excluded by!**/*.jpgstatic/img/blackbox/12.jpgis excluded by!**/*.jpgstatic/img/blackbox/13.jpgis excluded by!**/*.jpgstatic/img/blackbox/2.jpgis excluded by!**/*.jpgstatic/img/blackbox/3.jpgis excluded by!**/*.jpgstatic/img/blackbox/4.jpgis excluded by!**/*.jpgstatic/img/blackbox/5.jpgis excluded by!**/*.jpgstatic/img/blackbox/6.jpgis excluded by!**/*.jpgstatic/img/blackbox/7.jpgis excluded by!**/*.jpgstatic/img/blackbox/8.jpgis excluded by!**/*.jpgstatic/img/blackbox/9.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_1.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_10.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_11.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_2.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_3.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_4.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_5.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_6.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_7.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_8.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_9.jpgis excluded by!**/*.jpg
📒 Files selected for processing (2)
docs/wiki/guides/current/BBE-MinMax-control-manual.md(4 hunks)docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-MinMax-control-manual.md
[grammar] ~11-~11: Ensure spelling is correct
Context: ...lick on Minimum or Maximum values field what you want to edit. The main context menu...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~52-~52: Ensure spelling is correct
Context: ... change MinMax values and select curves what you need by using the checkboxes to app...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~54-~54: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...or click 'Close' menu item to close it. Click 'Apply change' or 'Cancel' button on th...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~86-~86: Ensure spelling is correct
Context: ...he zoom percent value and select curves what you need by using the checkboxes to app...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md
[grammar] ~27-~27: Ensure spelling is correct
Context: ... chart - "Limit dBm" - the power values what are less this limit are showed as black...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~36-~36: Ensure spelling is correct
Context: ...e power spectral density by RPM is more helpfull, when the RPM filter works. 
[grammar] ~43-~43: Ensure spelling is correct
Context: ...m chart. It possible to compare up to 6 spectrums. To compare PSD spectrums for one log f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.17.2)
docs/wiki/guides/current/BBE-MinMax-control-manual.md
50-50: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
68-68: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
76-76: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
84-84: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
92-92: Trailing punctuation in heading
Punctuation: '.'
(MD026, no-trailing-punctuation)
100-100: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: build
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (1)
11-12: List all available PSD chart types near the top (re-raise)A concise list (Standard PSD, PSD-vs-RPM, PSD-vs-Throttle) would orient readers before diving into details.
This mirrors feedback already given in a previous review.
🧹 Nitpick comments (9)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (9)
3-10: Polish intro wording & fix dB math bulletsMinor language issues reduce readability and the dB / power-ratio examples are hard to parse.
- The Blackbox Explorers spectrum analyser can show power spectral density (PSD) charts +The Blackbox Explorer’s spectrum analyzer can display power-spectral-density (PSD) charts. - The power spectral density charts show the noises level in standard dBm/Hz units. +PSD charts express noise level in standard dBm/Hz units. - For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +For example: +* Every **10 dBm** difference corresponds to a **10×** change in noise power (20 dBm → 100×, 30 dBm → 1 000×). +* Every **20 dBm** difference corresponds to a **10×** change in noise amplitude (40 dBm → 100×, 80 dBm → 1 000×).
15-18: Clarify smoothing & value-readout description- The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. +Use the vertical slider to adjust curve smoothing; lower smoothing increases frequency resolution. - The mouse cursor shows current power values by pressing Shift key +Hold **Shift** while hovering to display the current power value.
24-29: Tighten wording of PSD-vs-RPM settings-It has the next settings by using the three number input fields in the right-up charts corner: -- "Max dBm" - to set maximum power level what is showed as white color at the chart -- "Min dBm" - to set minimum power level what is showed as black color at the chart -- "Limit dBm" - the power values what are less this limit are showed as black +Three numeric fields in the upper-right corner control color mapping: +* **Max dBm** – power level rendered as white +* **Min dBm** – power level rendered as black +* **Limit dBm** – values below this threshold are also rendered black- The mouse cursor shows current power values by pressing Shift key +Hold **Shift** while hovering to display the current power value.
32-37: Fix typos in PSD-vs-Throttle section-It shows the noises power spectral density by frequency and throttle. +It displays noise power spectral density by frequency and throttle. -It looks like power spectral density by RPM. +Its layout is similar to the PSD-vs-RPM chart. -But the power spectral density by RPM is more helpfull, when the RPM filter works. +However, the PSD-vs-RPM chart is usually more helpful when the RPM filter is active.
40-44: Heading/anchor & grammar touch-ups
- Using a second top-level
#header breaks the hierarchy—##is sufficient.- Anchor can be dropped; GitHub auto-generates ids.
- “It possible” → “It is possible”, “spectrums” → “spectra”.
-# <a name="spectrum_comparison">Blackbox Explorer: Power spectral density curves comparison</a> +## Blackbox Explorer: Power-spectral-density curves comparison -It possible to compare several spectrums by using of power spectral density spectrum chart. -It possible to compare up to 6 spectrums. +It is possible to compare several spectra on the PSD chart (up to six at once).
45-51: Streamline bullet list (single-log comparison)-- to show "Power spectral density" chart for curve -- to select several curves by Ctrl + Mouse click at the curves legend -- to analyse spectrums difference -- to press "Clr" button to remove the all compared curves -- to repeate Ctr + Mouse click at some curve to remove it from comparison +- Open the **Power spectral density** chart for the curve. +- Select multiple curves with **Ctrl + click** in the legend. +- Analyse the differences between the spectra. +- Click **Clr** to clear all comparison curves. +- To remove a single curve, repeat **Ctrl + click** on it.
53-60: Streamline bullet list (cross-log comparison) & fix typos-- to show "Power spectral density" for the first log file curve -- to press "Exp" (Export) button. The spectrum data will exported to .CSV file -- to export spectrums from some log files what you need for comparison -- to show "Power spectral density" to compare some curve with other -- to press "Imp" (Import) button. To select several exported curves log files for comparison by using Open file dialog -- the sepctrums will showed at one chart for analyses +- Open the **Power spectral density** chart for the first log file. +- Click **Exp** (export) to save the spectrum to a `.csv` file. +- Export spectra from any additional log files you want to compare. +- Open the PSD chart for the curve you want as reference. +- Click **Imp** (import) and select the exported `.csv` files. +- All selected spectra are shown on one chart for analysis.
63-64: Minor wording & verb tense-The legends width and position can set in User settings dialog box +Legend width and position can be configured in the **User Settings** dialog.
4-61: Add meaningful alt text to all imagesAll
![image]()placeholders should be replaced with descriptive alt text (e.g.,![PSD chart overview]()), both for accessibility and for users browsing with images disabled.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md
[grammar] ~27-~27: Ensure spelling is correct
Context: ... chart - "Limit dBm" - the power values what are less this limit are showed as black...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~36-~36: Ensure spelling is correct
Context: ...e power spectral density by RPM is more helpfull, when the RPM filter works. 
[grammar] ~43-~43: Ensure spelling is correct
Context: ...m chart. It possible to compare up to 6 spectrums. To compare PSD spectrums for one log f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
|
@demvlad merged 558 and you are right it would conflict 
|
|
|
@coderabbitai Please check this PR after resolving of merge conflict |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (1)
42-44: List the six selectable spectra (repeat of prior review)The earlier review already asked for a concrete list after “It possible to compare up to 6 spectrums.”
Suggest expanding with an explicit bullet list or table naming the six colours/indices used by BBE.
🧹 Nitpick comments (7)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md (7)
3-4: Fix possessive apostrophe and apply 3rd-person singular to “Explorer”-The Blackbox Explorers spectrum analyser can show power spectral density (PSD) charts +The Blackbox Explorer’s spectrum analyzer can display power spectral density (PSD) chartsMinor language polish; keeps tone consistent with the rest of the docs.
6-10: Correct plural/grammar in dBm explanation-The power spectral density charts show the noises level in standard dBm/Hz units. -For example: -- every 10dBm values difference mean the noise power relation as 10, 20dBm as 100, 30dBm as 1000 -- every 20dBm values difference mean the noise amplitude relation as 10, 40dBm as 100, 80dBm as 1000 +Power spectral density charts show noise levels in standard dBm/Hz units. +For example: +– every 10 dB difference means the noise power ratio is ×10 (20 dB → ×100, 30 dB → ×1000) +– every 20 dB difference means the noise amplitude ratio is ×10 (40 dB → ×100, 60 dB → ×1000)Tightens wording and fixes “noises level” / “values difference” phrasing.
15-18: Clarify slider description & Shift-hover hint-The vertical slider can change curves smooth. The less smooth curve has more frequency resolution. +Use the vertical “Smoothing” slider to control curve smoothness: less smoothing gives higher frequency resolution.Line 18 already shows the Shift-hover image; consider adding “…by holding Shift while hovering” for clarity.
24-28: Tighten wording & fix “what is showed”-It has the next settings by using the three number input fields in the right-up charts corner: -- "Max dBm" - to set maximum power level what is showed as white color at the chart -- "Min dBm" - to set minimum power level what is showed as black color at the chart -- "Limit dBm" - the power values what are less this limit are showed as black +Configure the heat-map with the three numeric fields in the upper-right corner: +• **Max dBm** – power shown as pure white +• **Min dBm** – power shown as pure black +• **Limit dBm** – values below this limit are forced to blackEliminates awkward phrasing and bullet-aligns the options.
32-38: Spell-check “helpfull” and streamline sentence-But the power spectral density by RPM is more helpfull, when the RPM filter works. +However, the RPM version is usually more helpful when the RPM filter is enabled.Minor polish only.
45-51: Fix typos and keyboard shortcut spelling- to analyse spectrums difference - to press "Clr" button to remove the all compared curves - to repeate Ctr + Mouse click at some curve to remove it from comparison + to analyse spectrum differences + press “Clr” to clear all compared curves + repeat Ctrl + click on a curve to remove it from the comparisonAlso consider “Ctrl+Click” formatting for consistency.
54-60: Correct spelling of “spectrums”, “exported”, and “sepctrums”- to press "Exp" (Export) button. The spectrum data will exported to .CSV file - to export spectrums from some log files what you need for comparison - to press "Imp" (Import) button. To select several exported curves log files for comparison by using Open file dialog - the sepctrums will showed at one chart for analyses + press “Exp” (Export). Spectrum data is exported to a .CSV file + export spectra from each log file you wish to compare + press “Imp” (Import) and select the exported CSV files in the file-open dialog + the spectra will then be displayed together on one chart for analysisEliminates multiple spelling errors.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
static/img/blackbox/psd_1.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_10.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_11.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_2.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_3.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_4.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_5.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_6.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_7.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_8.jpgis excluded by!**/*.jpgstatic/img/blackbox/psd_9.jpgis excluded by!**/*.jpg
📒 Files selected for processing (2)
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md(1 hunks)docs/wiki/guides/current/Black-Box-logging-and-usage.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/wiki/guides/current/Black-Box-logging-and-usage.md
🧰 Additional context used
🪛 LanguageTool
docs/wiki/guides/current/BBE-Power-Spectral-Density-charts.md
[grammar] ~27-~27: Ensure spelling is correct
Context: ... chart - "Limit dBm" - the power values what are less this limit are showed as black...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~36-~36: Ensure spelling is correct
Context: ...e power spectral density by RPM is more helpfull, when the RPM filter works. 
[grammar] ~43-~43: Ensure spelling is correct
Context: ...m chart. It possible to compare up to 6 spectrums. To compare PSD spectrums for one log f...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: build
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@demvlad, I'll check the current state of the PR and help you identify what needs to be resolved after the merge conflict. 🏁 Script executed: Length of output: 3234 @demvlad, Great news! 🎉 The merge conflict appears to have been resolved already. Here's what I found: ✅ Current Status:
📊 Image Verification:
🔍 PR Review Summary: Ready for final approval! 🚀 🏁 Script executed: Length of output: 274 Let me fix that script and complete the verification: Perfect! 🎉 The PR has been successfully resolved and is in excellent condition: ✅ Final Verification Complete:
📋 PR Summary:
The merge conflict has been resolved and everything is working perfectly. Ready for approval and merge! 🚀 🏁 Script executed: Length of output: 3769 @demvlad Perfect! ✅ Your PR has been successfully checked and is in excellent condition after resolving the merge conflict: 🎯 Verification Results:
📋 PR Summary:
The merge conflict from PR #558 has been resolved perfectly, with both PSD images (this PR) and min-max images coexisting properly in the same directory. Ready for merge! 🚀 |
|
Preview URL: https://87ef01e8.betaflight-com.pages.dev |
Added manual for Power spectral density spectrums chart