Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 15, 2025

Checklist

  • passed schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added support for the SIMPLIFLYH7 flight controller.
    • Enables on-board SPI gyro/accelerometer, barometer (BMP280), OSD, and onboard flash (blackbox).
    • Preconfigured I/O: 4 motor outputs, 4 servos, multiple UARTs, I2C/SPI buses, status LED, beeper, and LED strip.
    • Camera control, PinIO with VTX power toggle, timer-channel pin mappings, and ADC-based voltage/current sensing with defaults.

@haslinghuis haslinghuis self-assigned this Oct 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Adds a new board configuration header for SIMPLIFLYH7 (STM32H743) that defines MCU/board/manufacturer IDs, feature flags, pin mappings (motors, UART, SPI, I2C, ADC, peripherals), timer mappings, DMA/SPI/I2C instances, defaults (blackbox/meter), and gyro SPI/EXTI/align settings.

Changes

Cohort / File(s) Summary of Changes
Board config: SIMPLIFLYH7
configs/SIMPLIFLYH7/config.h
New board config header adding FC_TARGET_MCU, BOARD_NAME, MANUFACTURER_ID; enables sensors/peripherals (USE_GYRO, USE_ACC, USE_BARO, USE_FLASH, USE_MAX7456, etc.); defines motor/servo/LED/UART/I2C/SPI/ADC/BEEPER/CAMERA/PINIO pins and CS/EXTI pins; adds TIMER_PIN_MAPPING; sets DMA options and SPI/I2C instance macros; sets defaults (blackbox, meter sources/scale, BEEPER_INVERTED, PINIO/BOX names); defines gyro SPI instance and alignment (GYRO_1_SPI_INSTANCE, GYRO_1_EXTI_PIN, GYRO_1_CS_PIN, GYRO_1_CLKIN_PIN, GYRO_1_ALIGN).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Areas to check:

  • Correctness of pin assignments and any overlap/conflicts (motors, UARTs, SPI/I2C).
  • TIMER_PIN_MAPPING entries vs. timer-capable pins.
  • DMA/SPI/I2C instance macros and consistency with MCU target.

Possibly related PRs

Suggested labels

New manufacturer, Schematics approved, Uses PX4 connector standard

Suggested reviewers

  • ot0tot
  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description consists solely of a checklist with no accompanying narrative or context. The template explicitly instructs authors to "Replace this text with details of your own," but the PR description provides only the checklist items without any explanation of what the SIMPLIFLYH7 board is, why it's being added, manufacturer information, or other relevant context. While the checklist items are mostly addressed, the critical requirement to provide a substantive description of the pull request has not been met. Additionally, the checklist marks "comments/issues resolved" as complete, but the PR objectives show ongoing discussion about flash configuration discrepancies that may not be fully resolved. The author should provide a comprehensive PR description that includes: a summary of the new board configuration being added, the manufacturer and hardware details, links to relevant documentation or design guidelines, a brief explanation of the board's capabilities, and any relevant technical notes. The template's informational sections should either be retained or explicitly removed if not applicable. Additionally, the "comments/issues resolved" checklist item should be verified to ensure all discussion points, particularly regarding the flash configuration mentioned in the PR comments, have been properly addressed before marking complete.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Add SIMPLIFLYH7" directly and clearly describes the primary change in the pull request, which is adding a new board configuration for the SIMPLIFLYH7 flight controller. The title is concise, specific, and immediately communicates the main objective of the changeset. It avoids vague language and provides sufficient clarity for someone scanning the repository history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • blind approval

@ot0tot
Copy link
Contributor

ot0tot commented Oct 19, 2025

What manufacturer is this? Can you link me to the Discord channel?

@haslinghuis
Copy link
Member Author

@ot0tot macfos

haslinghuis and others added 2 commits October 19, 2025 22:26
Updated current meter scale and PINIO1_BOX value.
@ot0tot
Copy link
Contributor

ot0tot commented Oct 19, 2025

Am I looking at the right schematic? Flash uses QuadSPI.

@haslinghuis
Copy link
Member Author

@ot0tot you received a prototype as quad spi was left out IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants