add jazzmutant osd preset #515
Conversation
|
Warning Rate limit exceeded@Jaz7Mutant has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 28 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds a new OSD preset file for JazzMutant HDZero at presets/4.5/osd/JazzMutant_HDZero_osd.txt with metadata, description, defaults include from presets/4.4/osd/defaults.txt, and explicit OSD positioning and bitmask settings; marked STATUS: EXPERIMENTAL. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
presets/4.5/osd/JazzMutant_HDZero_osd.txt (2)
6-7: Metadata polish: spacing and trailing whitespace
- Add a space after the KEYWORDS colon for consistency with other presets.
- Remove the trailing space after the AUTHOR name.
-#$ KEYWORDS:hdzero, HD, HDOSD, OSD, JazzMutant, racing +#$ KEYWORDS: hdzero, HD, HDOSD, OSD, JazzMutant, racing -#$ AUTHOR: JazzMutant +#$ AUTHOR: JazzMutant
16-19: Stabilize preview image URL and remove inline styleThe current URL returns HTTP 200 (image/jpeg) but points to a branch in a fork, which could vanish and break the link. We should:
• Add the preview JPEG into this repo (e.g.
images/osd/jazzmutant_osd_preset.jpeg) in this PR.
• Reference it via an immutable commit SHA (or at leastmaster) rather than the fork’s branch.
• Remove the inlinestyle="width:100%"since the Configurator strips inline styles.Suggested diff (after adding
images/osd/jazzmutant_osd_preset.jpeg):presets/4.5/osd/JazzMutant_HDZero_osd.txt @@ Lines 16-19 -#$ DESCRIPTION: <img src="https://raw.githubusercontent.com/Jaz7Mutant/firmware-presets/refs/heads/images/misc/images/jazzmutant_osd_preset.jpeg" style="width:100%"/> +#$ DESCRIPTION: <img src="https://raw.githubusercontent.com/betaflight/firmware-presets/<COMMIT_SHA>/images/osd/jazzmutant_osd_preset.jpeg"/>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
presets/4.5/osd/JazzMutant_HDZero_osd.txt(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-20T20:39:08.723Z
Learnt from: Jaz7Mutant
PR: betaflight/firmware-presets#512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Applied to files:
presets/4.5/osd/JazzMutant_HDZero_osd.txt
🪛 LanguageTool
presets/4.5/osd/JazzMutant_HDZero_osd.txt
[grammar] ~1-~1: There might be a mistake here.
Context: #$ TITLE: JazzMutant HDZero OSD #$ FIRMWARE_VERSION: 4.4 #$ FIRMWARE_VER...
(QB_NEW_EN)
[grammar] ~2-~2: There might be a mistake here.
Context: ...tant HDZero OSD #$ FIRMWARE_VERSION: 4.4 #$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OS...
(QB_NEW_EN)
[grammar] ~3-~3: There might be a mistake here.
Context: ...RE_VERSION: 4.4 #$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL...
(QB_NEW_EN)
[grammar] ~4-~4: There might be a mistake here.
Context: ...$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL #$ KEYWORDS:hdze...
(QB_NEW_EN)
[grammar] ~5-~5: There might be a mistake here.
Context: ...#$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL #$ KEYWORDS:hdzero, HD, HDOSD, OSD, Jazz...
(QB_NEW_EN)
[grammar] ~6-~6: There might be a mistake here.
Context: ...zero, HD, HDOSD, OSD, JazzMutant, racing #$ AUTHOR: JazzMutant #$ PARSER: MARKED...
(QB_NEW_EN)
[grammar] ~7-~7: There might be a mistake here.
Context: ...azzMutant, racing #$ AUTHOR: JazzMutant #$ PARSER: MARKED #$ DESCRIPTION:
J...
(QB_NEW_EN)
[grammar] ~13-~13: There might be a mistake here.
Context: ...pect ratio cameras. #$ DESCRIPTION:
#$ DESCRIPTION: You will also need to se...
(QB_NEW_EN)
[grammar] ~14-~14: There might be a mistake here.
Context: ...n the appropriate port in the ports tab. #$ DESCRIPTION: #$ DESCRIPTION:
Pre...
(QB_NEW_EN)
[grammar] ~15-~15: There might be a mistake here.
Context: ... port in the ports tab. #$ DESCRIPTION: #$ DESCRIPTION:
Preview:
#$ DESCRIPTION: <img ...(QB_NEW_EN)
[grammar] ~16-~16: There might be a mistake here.
Context: ...TION: #$ DESCRIPTION:
Preview:
#$ DESCRIPTION: <img src="https://raw.gi...(QB_NEW_EN)
[grammar] ~17-~17: There might be a mistake here.
Context: ...nt_osd_preset.jpeg" style="width:100%"/> #$ DESCRIPTION: #$ DISCUSSION: https://...
(QB_NEW_EN)
[grammar] ~18-~18: There might be a mistake here.
Context: ...g" style="width:100%"/> #$ DESCRIPTION: #$ DISCUSSION: https://github.com/betafl...
(QB_NEW_EN)
🔇 Additional comments (2)
presets/4.5/osd/JazzMutant_HDZero_osd.txt (2)
21-21: Including 4.4 OSD defaults is acceptable and consistent with project patternsRe-using defaults from presets/4.4/osd/defaults.txt for a 4.5 preset aligns with how other preset categories share cross-version defaults when identical. Looks good.
If you want, I can run a quick repo check to ensure presets/4.4/osd/defaults.txt exists in this branch and is referenced elsewhere similarly.
23-35: All OSD position keys validated; please verify warn/stat bitmask mappings
- presets/4.5/osd/JazzMutant_HDZero_osd.txt (lines 23–35):
• osd_warn_bitmask = 270333
• osd_stat_bitmask = 1882194596- All
osd_*_poskeys match other 4.5 presets and the 4.4 defaults file.Although element names are correct, ensure that those bitmask values correspond to the desired warning and stat flags in Betaflight 4.5—enumeration bit positions can shift between major releases.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
presets/4.5/osd/JazzMutant_HDZero_osd.txt (2)
6-6: Keywords align with prior suggestion—niceMatches the suggested set and should aid discoverability.
14-14: Quote closure and Ports casing fixed—thanksThe missing closing quote and “Ports” capitalization from the earlier review are correctly resolved.
🧹 Nitpick comments (3)
presets/4.5/osd/JazzMutant_HDZero_osd.txt (3)
7-7: Trim trailing space on AUTHOR lineMinor formatting nit: there’s an extra space after the author name.
Apply this diff:
-#$ AUTHOR: JazzMutant +#$ AUTHOR: JazzMutant
10-10: Make TITLE and H1 consistentMinor wording mismatch: TITLE is “JazzMutant HDZero OSD” while H1 says “JazzMutant HDZero race OSD”. Pick one to avoid confusion in UIs that show both.
For consistency, either include “race” in TITLE or remove it from H1. Example (remove from H1):
-#$ DESCRIPTION: <h1>JazzMutant HDZero race OSD</h1> +#$ DESCRIPTION: <h1>JazzMutant HDZero OSD</h1>
17-17: Pin preview image to a permalink to avoid future 404sLinking to a branch path can break if the branch is deleted/renamed. Prefer a commit permalink or a stable branch like master/main after merge.
Example of a committed permalink format (replace with the image commit SHA):
https://raw.githubusercontent.com/Jaz7Mutant/firmware-presets/<commit>/images/misc/images/jazzmutant_osd_preset.jpeg
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
presets/4.5/osd/JazzMutant_HDZero_osd.txt(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-20T20:39:08.723Z
Learnt from: Jaz7Mutant
PR: betaflight/firmware-presets#512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Applied to files:
presets/4.5/osd/JazzMutant_HDZero_osd.txt
🪛 LanguageTool
presets/4.5/osd/JazzMutant_HDZero_osd.txt
[grammar] ~1-~1: There might be a mistake here.
Context: #$ TITLE: JazzMutant HDZero OSD #$ FIRMWARE_VERSION: 4.4 #$ FIRMWARE_VER...
(QB_NEW_EN)
[grammar] ~2-~2: There might be a mistake here.
Context: ...tant HDZero OSD #$ FIRMWARE_VERSION: 4.4 #$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OS...
(QB_NEW_EN)
[grammar] ~3-~3: There might be a mistake here.
Context: ...RE_VERSION: 4.4 #$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL...
(QB_NEW_EN)
[grammar] ~4-~4: There might be a mistake here.
Context: ...$ FIRMWARE_VERSION: 4.5 #$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL #$ KEYWORDS: HDZ...
(QB_NEW_EN)
[grammar] ~5-~5: There might be a mistake here.
Context: ...#$ CATEGORY: OSD #$ STATUS: EXPERIMENTAL #$ KEYWORDS: HDZERO, HD, HDOSD, OSD, Jaz...
(QB_NEW_EN)
[grammar] ~6-~6: There might be a mistake here.
Context: ...ZERO, HD, HDOSD, OSD, JazzMutant, Racing #$ AUTHOR: JazzMutant #$ PARSER: MARKED...
(QB_NEW_EN)
[grammar] ~7-~7: There might be a mistake here.
Context: ...azzMutant, Racing #$ AUTHOR: JazzMutant #$ PARSER: MARKED #$ DESCRIPTION:
J...
(QB_NEW_EN)
[grammar] ~13-~13: There might be a mistake here.
Context: ...pect ratio cameras. #$ DESCRIPTION:
#$ DESCRIPTION: You will also need to se...
(QB_NEW_EN)
[grammar] ~14-~14: There might be a mistake here.
Context: ...n the appropriate port in the Ports tab. #$ DESCRIPTION: #$ DESCRIPTION:
Pre...
(QB_NEW_EN)
[grammar] ~15-~15: There might be a mistake here.
Context: ... port in the Ports tab. #$ DESCRIPTION: #$ DESCRIPTION:
Preview:
#$ DES...(QB_NEW_EN)
[grammar] ~16-~16: There might be a mistake here.
Context: ...TION: #$ DESCRIPTION:
Preview:
#$ DESCRIPTION: <img src="https://raw.gi...(QB_NEW_EN)
[grammar] ~17-~17: There might be a mistake here.
Context: ...nt_osd_preset.jpeg" style="width:100%"/> #$ DESCRIPTION: #$ DISCUSSION: https://...
(QB_NEW_EN)
[grammar] ~18-~18: There might be a mistake here.
Context: ...g" style="width:100%"/> #$ DESCRIPTION: #$ DISCUSSION: https://github.com/betafl...
(QB_NEW_EN)
🔇 Additional comments (5)
presets/4.5/osd/JazzMutant_HDZero_osd.txt (5)
1-9: Metadata block looks solid and follows presets conventionsTITLE, FIRMWARE_VERSIONs, CATEGORY, STATUS, KEYWORDS, AUTHOR, and PARSER lines are present and well-formed for a presets file.
19-19: Discussion link present and correctHaving a DISCUSSION link to the PR is helpful for users to report issues or ask questions.
21-21: Include Path Confirmed – No Action NeededConfirmed that
presets/4.4/osd/defaults.txtexists in the repo. The include on line 21 ofpresets/4.5/osd/JazzMutant_HDZero_osd.txtis valid.
23-35: OSD field compatibility confirmed across 4.4 and 4.5All of the
osd_*keys set inpresets/4.5/osd/JazzMutant_HDZero_osd.txt—includingosd_rate_profile_name_pos—are defined inpresets/4.4/osd/defaults.txt. No keys are missing for 4.4, so no version gating or omissions are required.
8-8: PARSER directive verified
The Configurator’s ParserEnum (in indexer/Settings.js) is["TEXT","MARKED"], and PresetsFile enforces only those two values. Using#$ PARSER: MARKEDis valid.
Jaz7Mutant
force-pushed
the
jazzmutant-osd-preset
branch
from
adbbc3a to
1c1c5e3
Compare
| #$ FIRMWARE_VERSION: 4.5 | ||
| #$ CATEGORY: OSD | ||
| #$ STATUS: EXPERIMENTAL | ||
| #$ KEYWORDS: HDZERO, HD, HDOSD, OSD, JazzMutant, Racing |
There was a problem hiding this comment.
Sorry, just checked other keywords in the repo - HDZERO should be HDzero here, but personal would ignore and use HDZERO or HDZero :)
| #$ KEYWORDS: HDZERO, HD, HDOSD, OSD, JazzMutant, Racing | |
| #$ KEYWORDS: HDzero HD, HDOSD, OSD, JazzMutant, Racing |
There was a problem hiding this comment.
Ok, I think I'll leave it as is
Preview can be found here: https://raw.githubusercontent.com/Jaz7Mutant/firmware-presets/refs/heads/images/misc/images/jazzmutant_osd_preset.jpeg
Summary by CodeRabbit
New Features
Documentation