Skip to content

CHECKOUT-9513: Hydrate initial state to reduce latency caused by request waterfalls #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+473 −415
Open

CHECKOUT-9513: Hydrate initial state to reduce latency caused by request waterfalls #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ workflows:
<<: *pull_request_filter
requires:
- build-prerelease
- sdk-on-cdn:
filters:
<<: *pull_request_filter
# - sdk-on-cdn:
# filters:
# <<: *pull_request_filter
- security/scan:
name: "Gitleaks secrets scan"
filters:
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"prettier": "@bigcommerce/eslint-config/prettier",
"homepage": "https://github.com/bigcommerce/checkout-js#readme",
"dependencies": {
"@bigcommerce/checkout-sdk": "^1.802.0",
"@bigcommerce/checkout-sdk": "github:bigcommerce/checkout-sdk-js#dbc080e6cd4d6647ec15d5c50916e9a70cd31007",
"@bigcommerce/citadel": "^2.15.1",
"@bigcommerce/form-poster": "^1.2.2",
"@bigcommerce/memoize": "^1.0.0",
Expand Down
102 changes: 62 additions & 40 deletions packages/core/src/app/billing/Billing.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
type BillingAddress,
type CheckoutInitialState,
type CheckoutService,
createCheckoutService,
createEmbeddedCheckoutMessenger,
Expand All @@ -23,12 +24,14 @@ import {
import {
CheckoutPageNodeObject,
CheckoutPreset,
checkoutSettings,
checkoutWithBillingEmail,
checkoutWithDigitalCart,
checkoutWithShipping,
checkoutWithShippingAndBilling,
consignment,
customer,
formFields,
payments,
shippingAddress,
shippingAddress2,
Expand Down Expand Up @@ -128,7 +131,9 @@ describe('Billing step', () => {
});

it('completes the billing step as a guest and goes to the payment step', async () => {
checkout.use(CheckoutPreset.CheckoutWithShipping);
checkoutService = checkout.use(CheckoutPreset.CheckoutWithShipping);

jest.spyOn(checkoutService, 'updateBillingAddress');

render(<CheckoutTest {...defaultProps} />);

Expand All @@ -153,7 +158,9 @@ describe('Billing step', () => {
});

it('edit the billing address and goes back to the payment step', async () => {
checkout.use(CheckoutPreset.CheckoutWithShippingAndBilling);
checkoutService = checkout.use(CheckoutPreset.CheckoutWithShippingAndBilling);

jest.spyOn(checkoutService, 'updateBillingAddress');

render(<CheckoutTest {...defaultProps} />);

Expand Down Expand Up @@ -186,14 +193,16 @@ describe('Billing step', () => {
});

it('should show order comments', async () => {
checkout.updateCheckout(
'get',
'/checkout/*',
{
...checkoutWithBillingEmail,
cart: checkoutWithDigitalCart.cart,
checkoutService = createCheckoutService({
initialState: {
config: checkoutSettings,
checkout: {
...checkoutWithBillingEmail,
cart: checkoutWithDigitalCart.cart,
},
formFields,
},
);
});

render(<CheckoutTest {...defaultProps} />);

Expand All @@ -203,17 +212,19 @@ describe('Billing step', () => {
});

it('should show PoweredByPayPalFastlaneLabel', async () => {
checkout.updateCheckout(
'get',
'/checkout/*',
{
...checkoutWithShipping,
billingAddress:checkoutWithBillingEmail.billingAddress,
payments:[
getCheckoutPayment(),
],
checkoutService = createCheckoutService({
initialState: {
config: checkoutSettings,
checkout: {
...checkoutWithShipping,
billingAddress:checkoutWithBillingEmail.billingAddress,
payments:[
getCheckoutPayment(),
],
},
formFields,
},
);
});

render(<CheckoutTest {...defaultProps} />);

Expand All @@ -223,11 +234,9 @@ describe('Billing step', () => {
});

it('should show PoweredByPayPalFastlaneLabel and custom form fields', async () => {
checkout.use(CheckoutPreset.CheckoutWithBillingEmailAndCustomFormFields);
checkout.updateCheckout(
'get',
'/checkout/*',
{
checkoutService = checkout.use(CheckoutPreset.CheckoutWithBillingEmailAndCustomFormFields, {
config: checkoutSettings,
checkout: {
...checkoutWithShipping,
billingAddress:checkoutWithBillingEmail.billingAddress,
consignments: [
Expand Down Expand Up @@ -273,7 +282,8 @@ describe('Billing step', () => {
getCheckoutPayment(),
],
},
);
formFields,
});

render(<CheckoutTest {...defaultProps} />);

Expand All @@ -292,11 +302,15 @@ describe('Billing step', () => {

describe('registered customer', () => {
it('completes the billing step after selecting a valid address', async () => {
checkout.updateCheckout(
'get',
'/checkout/*',
checkoutWithCustomer
);
checkoutService = createCheckoutService({
initialState: {
config: checkoutSettings,
checkout: checkoutWithCustomer,
formFields,
},
});

jest.spyOn(checkoutService, 'updateBillingAddress');

render(<CheckoutTest {...defaultProps} />);

Expand Down Expand Up @@ -354,11 +368,15 @@ describe('Billing step', () => {
phone: shippingAddress3.phone,
} as BillingAddress;

checkout.updateCheckout(
'get',
'/checkout/*',
checkoutWithCustomer
);
checkoutService = createCheckoutService({
initialState: {
config: checkoutSettings,
checkout: checkoutWithCustomer,
formFields,
},
});

jest.spyOn(checkoutService, 'updateBillingAddress');

render(<CheckoutTest {...defaultProps} />);

Expand Down Expand Up @@ -405,11 +423,15 @@ describe('Billing step', () => {
});

it('completes the billing step after creating a new address even with existing addresses', async () => {
checkout.updateCheckout(
'get',
'/checkout/*',
checkoutWithCustomer
);
checkoutService = createCheckoutService({
initialState: {
config: checkoutSettings,
checkout: checkoutWithCustomer,
formFields,
},
});

jest.spyOn(checkoutService, 'updateBillingAddress');

render(<CheckoutTest {...defaultProps} />);

Expand Down
Loading