refactor(checkout): CHECKOUT-9386 Convert ManageInstrumentsModal #2554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-peng
changed the title
richapatel1510
approved these changes
Sep 4, 2025
|
Please add a screenshot to PR. |
@vitalii-koshovyi Thanks for the reminder. I have attached two manual testing videos to the description. |
bc-peng
force-pushed
the
ManageInstrumentsModal
branch
from
c60fbaa to
87836fc
Compare
|
checkout-js deployed to Integration US |
|
checkout-js deployed to Staging US |
⚡️ Lighthouse results🖥️ Desktop:
📱 Mobile:
|
|
checkout-js deployed to Production US |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Convert class component
ManageInstrumentsModalinto function component.Replacing class components with function components eliminates the need for traditional lifecycle methods and enables full adoption of React 18 features like hooks and concurrent rendering.
This modernization aligns with React’s roadmap and ensures greater compatibility with future updates.
Rollout/Rollback
Revert.
Testing
Manual Testing
Delete flow
Screen.Recording.2025-09-12.at.11.52.34.mov
Cancel flow
Screen.Recording.2025-09-12.at.11.51.17.mov