Copilot/auto sync updates - #25
Open
5hy7xz92nd-oss wants to merge 168 commits into
Open
Conversation
…test-run-develop-repeat Add repository-wide PoC validation and regression coverage
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
…phic-blueprint
…ck-merge-into-13
…zed-architecture
…evelopment-101
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (3)
tests/test_validate_pocs.py:11
- The unittest suite implicitly requires
nodeto be installed (because validate_repo validates JS vianode --check), which will cause the entire test run to fail in Python-only environments. Consider skipping these tests whennodeis unavailable (CI already installs it).
def setUp(self) -> None:
self.repo_root = Path(__file__).resolve().parents[1]
.github/instructions/*.instructions.md:3
- This file name contains a literal
*character (.github/instructions/*.instructions.md), which breaks checkouts on Windows (invalid filename) and is likely accidental. The file contents also appear to be unrelated PR/chat logs and emoji spam rather than actionable Copilot instructions—please remove it or replace it with concise repository instructions under a valid filename.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
validate_pocs.py:284
- Typo in the discovery sanity error message: “validateable” should be “validatable” (this string is user-facing and will be printed on failure).
"discovery returned no validateable files despite PoC content on disk; "
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (4)
tests/test_validate_pocs.py:11
- Most tests depend on Node being available (because fixtures include
.jsfiles andvalidate_repo()enforcesnode --check). Add asetUp()guard to skip these tests whennodeis not installed, so the suite fails for real validation issues rather than missing local tooling.
def setUp(self) -> None:
self.repo_root = Path(__file__).resolve().parents[1]
tests/test_validate_pocs.py:4
- Tests call
validate_repo()which requiresnodewhen any.jsfixtures are present, but the test module never importsshutil(needed to detect node) and currently can't skip cleanly when Node isn't installed.
import json
import tempfile
import unittest
from pathlib import Path
.github/instructions/*.instructions.md:5
- This Copilot instructions file appears to contain large amounts of unrelated/duplicated text (including external links) and is named literally
*.instructions.md(with a*in the filename). This is likely accidental or autogenerated noise and can interfere with tooling that consumes.github/instructionscontent; please remove it or replace it with concise, repo-relevant instructions.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
validate_pocs.py:101
py_compile.compile(..., doraise=True)can raiseOSError(e.g., unreadable/missing file). Right now that would crash the validator instead of reporting a collected error like the other validators do.
try:
py_compile.compile(str(path), doraise=True)
except py_compile.PyCompileError as exc: # pragma: no cover - covered via broken fixtures
errors.append(f"{path.relative_to(root)}: {exc}")
…phic-blueprint Merge pull request #36 from 5hy7xz92nd-oss/main
…s table Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.