Cuda support via the extension mechanism and switching from ShiftedArrays.jl to MutableShiftedArrays.jl #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jl, to enable clean CUDA support
Member
|
Ok looks better. I think we have to do a breaking release as many types have changed. Did you test type stability with @code_warntype? |
Member
Author
|
No, I did not. Any specific function I should test, or just any of the ones that use the CUDA extension or select_region_view ? |
Member
|
Shall we merge? |
Member
Author
|
Yes, we can merge in my opinion. |
…ed to 0.3.1 for MutableShiftedArrays.jl which also fixed a bug (missing similar).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 94.03% 93.11% -0.92%
==========================================
Files 19 20 +1
Lines 1173 1206 +33
==========================================
+ Hits 1103 1123 +20
- Misses 70 83 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Can we merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another fresh attempt to gain CUDA support.
It needs the very recent, just released version 0.8.1 of NDTools.jl to work (using the select_region_view() function).
Also the classes internal to FourierTools.jl have been extended via the Adapt mechanism.
The direction paramater was also moved to a Val() type.
The CircShiftedArray type is now supplied by
MutableShiftedArrays.jlwhich already has CUDA support via the Adapt mechanism.Some type supplied by FourierTools.jl are made CUDA compatible via the Adapt mechanism in the èxt` folder based on type Unions.