Skip to content

Show/Hide pool advanced options - #1149

Merged
WantClue merged 4 commits into
bitaxeorg:masterfrom
duckaxe:feature/show-pool-advanced-options
Jul 27, 2025
Merged

WantClue merged 4 commits into
bitaxeorg:masterfrom
duckaxe:feature/show-pool-advanced-options

Conversation

@duckaxe

@duckaxe duckaxe commented Jul 15, 2025

Copy link
Copy Markdown
Collaborator

Since v2.9.0, I've often seen people asking for the new pool options, Suggested Difficulty and Extranonce Subscribe. To avoid confusing beginners and reduce the number of support requests, this pull request puts both options in a show/hide wrapper and marks them as "advanced" fields.

ShowAdvancedOptions.mov

@github-actions

github-actions Bot commented Jul 15, 2025 •

Copy link
Copy Markdown

Test Results

20 tests  ±0   20 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ea1d3e6. ± Comparison against base commit e41ad8e.

♻️ This comment has been updated with latest results.

@WantClue WantClue added the design Design Enhancements label Jul 15, 2025
@WantClue WantClue added this to the 2.10.0 milestone Jul 15, 2025

@WantClue WantClue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, added a tooltip for the suggestDiff as well

@johnny9 johnny9 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

tested on a 201. Looks great.

@duckaxe

duckaxe commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator Author

@WantClue I would't add tooltip in this PR because @mutatrum created already a PR for that #1134

@duckaxe

duckaxe commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator Author

After talking to @WantClue , I removed the tooltip so that we can add it with #1134 .

@WantClue
WantClue merged commit 69569b6 into bitaxeorg:master Jul 27, 2025
@duckaxe
duckaxe deleted the feature/show-pool-advanced-options branch November 4, 2025 08:06
bitmernmining pushed a commit to bitmernmining/ESP-Miner that referenced this pull request Sep 9, 2026
* Show/Hide pool advanced options

* Add pool sensitive handling

* fix: add pTooltip to suggestDiff

* Remove tooltip from Suggested Difficulty

---------

Co-authored-by: duckAxe <>
Co-authored-by: WantClue <86001033+WantClue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Design Enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants