Skip to content

Conversation

@yoolen
Copy link

@yoolen yoolen commented Aug 7, 2025

Resolves #1127.

  • Info icon and tooltips added for Hostname fields in the Network and Swarm sections.

Network

network section

Swarm

swarm section
  • Added a constants.ts file with a TOOLTIPS enum for shared constants.

NOTE: Encountered an issue with PrimeNG where hover and focus cannot both be applied to an element (https://github.com/orgs/primefaces/discussions/1409); this means that the tooltips will only work for either desktop or mobile, but not both at the same time. In keeping with the current code examples, I've gone with the default hover. It may be worthwhile to consider a custom directive (would have to maintain it) or another library (such as ng-bootstrap) that handles both cases properly to replace PrimeNG.

@yoolen yoolen changed the title enhancement(axeOS): Add network tooltips enhancement(axe-os): Add network tooltips Aug 7, 2025
@duckaxe
Copy link
Contributor

duckaxe commented Aug 7, 2025

Hey, please look at #1175
After #1175 is merged, we would start a new PR where we add tooltips to necessary labels. Not only for hostname. There are many labels that need a tooltip with help messages.

@yoolen
Copy link
Author

yoolen commented Aug 7, 2025

Hey, please look at #1175 After #1175 is merged, we would start a new PR where we add tooltips to necessary labels. Not only for hostname. There are many labels that need a tooltip with help messages.

@duckaxe This is great! Sorry I didn't realize you'd already worked on the custom component. I'll merge your branch and swap over to using your tooltip component.

I believe having the contents of the tooltips in a constants file would make it easier to make changes moving forward. Let me know if this approach is acceptable and I'll pull the other tooltips out and do a refactor. This would also help with internationalization in the future to support other languages.

@skot
Copy link
Collaborator

skot commented Aug 7, 2025

+1 on changes to make future localization easier!

@duckaxe
Copy link
Contributor

duckaxe commented Aug 7, 2025

Honestly, I would close this PR because it's not doing anything at this point.

My preferred order would be:

  • Localization

Small steps, big impact.

If you want, you can start a thread and begin collecting tooltip messages.

@yoolen
Copy link
Author

yoolen commented Aug 7, 2025

Honestly, I would close this PR because it's not doing anything at this point.

My preferred order would be:

Small steps, big impact.

If you want, you can start a thread and begin collecting tooltip messages.

Works for me. I'll get started on that.

@yoolen yoolen closed this Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network Configuration

3 participants