Skip to content

Conversation

@terratec
Copy link
Contributor

@terratec terratec commented May 3, 2025

No description provided.

@terratec terratec force-pushed the show_highest_temperature branch from 367f094 to 221fdc9 Compare May 3, 2025 12:53
@WantClue WantClue force-pushed the dev-latest branch 2 times, most recently from e09e1e8 to daf1233 Compare May 5, 2025 18:20
@terratec terratec force-pushed the show_highest_temperature branch from 221fdc9 to 65932a4 Compare May 25, 2025 14:09
@duckaxe
Copy link
Collaborator

duckaxe commented May 25, 2025

@terratec Could you please confirm whether we need this functionality? With the new PID temperature control, you set the target temperature, which is then maintained constantly. Therefore, the temperature will always be constant and never change. I have several devices, and the temperature has remained constant since the restart.

@terratec
Copy link
Contributor Author

@terratec Could you please confirm whether we need this functionality? With the new PID temperature control, you set the target temperature, which is then maintained constantly. Therefore, the temperature will always be constant and never change. I have several devices, and the temperature has remained constant since the restart.

I think this can be useful for manual fan control setting or for hot environments (100% fan speed, either PID or manual)?

@duckaxe
Copy link
Collaborator

duckaxe commented May 26, 2025

I think this can be useful for manual fan control setting or for hot environments (100% fan speed, either PID or manual)?

I get the idea, and it's a good one. Most users will use PID, so they will have two values on the dashboard that never change.

@mutatrum
Copy link
Collaborator

I get the idea, and it's a good one. Most users will use PID, so they will have two values on the dashboard that never change.

It's possible the PID controller, when set a too low target temperature, cannot hold it. So even when using PID, it's a useful indicator.

A more sophisticated version would be a 24hr high and low value, but that's outside the scope here.

@mutatrum mutatrum added the enhancement New feature or request label May 30, 2025
@terratec terratec force-pushed the show_highest_temperature branch 2 times, most recently from ba98d20 to d9b4815 Compare June 18, 2025 17:16
@duckaxe
Copy link
Collaborator

duckaxe commented Jun 19, 2025

@terratec I pushed a commit to my local branch to fix the uptime table terratec@d1372c9

Your change is good, but it's better. colspan=2 can be removed

Yours
Screenshot 2025-06-19 at 09 10 08

Mine
Screenshot 2025-06-19 at 09 07 41

@duckaxe
Copy link
Collaborator

duckaxe commented Jun 26, 2025

@terratec pls solve merge conflicts. there is also an open requested change.

@terratec terratec force-pushed the show_highest_temperature branch from 5b79f9a to c9d9655 Compare June 26, 2025 17:08
@terratec
Copy link
Contributor Author

@terratec pls solve merge conflicts. there is also an open requested change.

Rebased and fixed the visibility for max VR temperature.
This seems to be an orphaned notice? As far as I can see, I have resolved all change requests

@duckaxe
Copy link
Collaborator

duckaxe commented Jun 26, 2025

@terratec According to #1077 I adjusted the Uptime card. Can you please apply the Card.patch. After that both cards should look similar.

Screenshot 2025-06-26 at 21 29 15

@terratec terratec force-pushed the show_highest_temperature branch from c9d9655 to 112fa7b Compare June 26, 2025 20:44
@WantClue WantClue self-requested a review July 7, 2025 18:34
@terratec terratec force-pushed the show_highest_temperature branch from 112fa7b to baeabde Compare July 23, 2025 14:30
@github-actions
Copy link

Test Results

20 tests  ±0   20 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit baeabde. ± Comparison against base commit 37b8315.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants