Skip to content

script, ci: add scripted diff checks #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Jul 20, 2025

so the CI verifies scripted-diff commits like cd19d89.

@jonatack jonatack force-pushed the 2025-07-scripted-diff-checks branch from 480fb4e to 344c06e Compare July 20, 2025 21:13
@jonatack jonatack marked this pull request as ready for review July 20, 2025 21:15
@jonatack jonatack force-pushed the 2025-07-scripted-diff-checks branch from 7b6e61e to c5ca1ab Compare August 1, 2025 20:46
-BEGIN VERIFY SCRIPT-
sed -i -e 's/BIP 2 was written in 2016./BIP 2 was written in 2018./g' $(git grep -l 'BIP 2 was written in 2016.')
-END VERIFY SCRIPT-
@jonatack jonatack force-pushed the 2025-07-scripted-diff-checks branch from c5ca1ab to 797f95f Compare August 1, 2025 20:50
@@ -21,7 +21,7 @@ address the evolving needs of the BIP process.

## Motivation

BIP 2 was written in 2016.
BIP 2 was written in 2017.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna say, I’m pretty sure that it was 2016, but I see now that you are just testing the CI.

Sorry that I haven’t reviewed this yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No worries, I'm not passing the commit range correctly yet, putting it back into draft.

@jonatack jonatack marked this pull request as draft August 2, 2025 14:01
@jonatack jonatack added the CI label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants