fix: treat HTTP 301 as permanent redirect - #829
Open
xhon-pelushi wants to merge 1 commit into
Open
Conversation
CalendarFetcher.onRedirect() matched HttpStatusCode.NotModified (304) instead of HttpStatusCode.MovedPermanently (301) when deciding whether a redirect is permanent. Since a 304 never reaches onRedirect() (it is intercepted earlier by fetchNetwork()), that branch was dead code, and real 301 responses fell into the temporary-redirect branch: the stored subscription URL was never updated via onNewPermanentUrl(), causing the 301 to be re-followed on every sync. Fixes bitfireAT#824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat HTTP 301 the same as 308 for permanent redirect handling when saving calendar URLs.
Fixes #824
Test plan