fix up base58 code

dynst · dynst · commit c4a61e00e472 · 2025-06-30T20:13:17.000Z
diff --git a/packages/bitcore-lib-cash/lib/encoding/base58.js b/packages/bitcore-lib-cash/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(chars.map((char) => { return ALPHABET.includes(char); }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib-doge/lib/encoding/base58.js b/packages/bitcore-lib-doge/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib-ltc/lib/encoding/base58.js b/packages/bitcore-lib-ltc/lib/encoding/base58.js
@@ -25,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {
diff --git a/packages/bitcore-lib/lib/encoding/base58.js b/packages/bitcore-lib/lib/encoding/base58.js
@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {
   if (buffer.Buffer.isBuffer(chars)) {
     chars = chars.toString();
   }
-  return _.every(chars.map((char) => { return ALPHABET.includes(char); }));
+  return [...chars].every(c => ALPHABET.includes(c));
 };
 
 Base58.prototype.set = function(obj) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ Base58.validCharacters = function validCharacters(chars) {`
`26`	`26`	`if (buffer.Buffer.isBuffer(chars)) {`
`27`	`27`	`chars = chars.toString();`
`28`	`28`	`}`
`29`		`- return _.every(chars.map((char) => { return ALPHABET.includes(char); }));`
	`29`	`+ return [...chars].every(c => ALPHABET.includes(c));`
`30`	`30`	`};`
`31`	`31`
`32`	`32`	`Base58.prototype.set = function(obj) {`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ Base58.validCharacters = function validCharacters(chars) {`
`25`	`25`	`if (Buffer.isBuffer(chars)) {`
`26`	`26`	`chars = chars.toString();`
`27`	`27`	`}`
`28`		`- return _.every(chars.map((char) => { return (ALPHABET.includes(char)) }));`
	`28`	`+ return [...chars].every(c => ALPHABET.includes(c));`
`29`	`29`	`};`
`30`	`30`
`31`	`31`	`Base58.prototype.set = function(obj) {`