Skip to content

Improve service registration #33

Description

@Tyrrrz

JIRA item: https://bitwarden.atlassian.net/browse/PAS-206


Based on the items raised in the "general feedback" meeting with me and @abergs.

Suggestion 1: rename AddPasswordlessSdk() to AddPassworless(). The Identity integration should either provide its own overloads with the same name (ideal) or have a separate method, like AddPasswordlessIdentity() (less ideal).

Suggestion 2: AddPasswordlessSdk() should either be callable without arguments (in which case the ApiKey/ApiSecret are resolved from conventional environment variables), or the options => ... overload should throw an exception when those two values aren't provided.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions