Skip to content

SRE-2330 cleanup references to auth-email #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sneakernuts
Copy link
Member

@sneakernuts sneakernuts commented May 23, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-2330

📔 Objective

Part of overall effort to deprecate auth-email header

Server side changes: bitwarden/server#5709

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented May 23, 2025

Logo
Checkmarx One – Scan Summary & Details515e83e3-f342-4961-8b2d-47bf438b6b03

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.19%. Comparing base (20e3dfa) to head (2d4356c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   74.19%   74.19%           
=======================================
  Files         253      253           
  Lines       21897    21894    -3     
=======================================
- Hits        16247    16245    -2     
+ Misses       5650     5649    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sneakernuts sneakernuts force-pushed the SRE-2330-deprecate-usage-of-auth-email-in-sdk-internal branch from d46814e to 2d4356c Compare August 14, 2025 18:51
Copy link

@sneakernuts sneakernuts marked this pull request as ready for review August 17, 2025 00:04
@sneakernuts sneakernuts requested a review from a team as a code owner August 17, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants