PM-23648: All Identities (passport, driving-license, id-doc, name) -> Identity #363
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cxf/sample #363 +/- ##
==============================================
+ Coverage 74.37% 74.89% +0.51%
==============================================
Files 253 254 +1
Lines 21918 22419 +501
==============================================
+ Hits 16302 16791 +489
- Misses 5616 5628 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
@audreyality If there are multiple documents in the CXF import then you'll have multiple identities stored in Bitwarden, one for each. In the future we may tro to de-dupe the incoming data, unless we find it breakes in cases like yours. However, we don't that in this PR so I think we're good? |
|
@abergs can you just rebase this on main directly. I don't think there's any reaason to base it on the sample. |
| (identity, custom_fields) | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
suggestion: Move sample usages to a new sample.rs, where you run our import flow and assert all the output at once.
There was a problem hiding this comment.
Will do as part of final cleanup once all items are mapped (do to logistics)
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
Co-authored-by: Oscar Hinton <[email protected]>
|
🎟️ Tracking
📔 Objective
This PR maps multiple identity documents to Identity + custom fields. PR was submitted in a rush, forgive me if it fails tests but would be worthwhile to have early reviews on my approach.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes