Skip to content

Conversation

fntyler
Copy link
Contributor

@fntyler fntyler commented Sep 17, 2025

🎟️ Tracking

BRE-1158

📔 Objective

Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 17, 2025

Logo
Checkmarx One – Scan Summary & Details4c37eb4c-bcc9-4adb-982b-18bf10f87d0d

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.48%. Comparing base (d7ce769) to head (7a65e53).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   78.48%   78.48%           
=======================================
  Files         276      276           
  Lines       27435    27435           
=======================================
  Hits        21531    21531           
  Misses       5904     5904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fntyler fntyler marked this pull request as ready for review September 17, 2025 17:31
@fntyler fntyler requested a review from a team as a code owner September 17, 2025 17:31
@fntyler fntyler requested a review from dereknance September 17, 2025 17:31
dereknance
dereknance previously approved these changes Sep 17, 2025
@Hinton
Copy link
Member

Hinton commented Sep 18, 2025

Do we want to exclude the current dockerfile since it's only the memory testing util which is solely for testing memory behaviour in CI and will never be published anywhere?

Copy link

@fntyler
Copy link
Contributor Author

fntyler commented Oct 1, 2025

Do we want to exclude the current dockerfile since it's only the memory testing util which is solely for testing memory behaviour in CI and will never be published anywhere?

I'm inclined to include the current dockerfile. This change is part of an effort to help maintain these internal practices.

@fntyler fntyler requested a review from dereknance October 1, 2025 16:44
@fntyler fntyler merged commit dc74855 into main Oct 1, 2025
50 checks passed
@fntyler fntyler deleted the bre/bre-1158/co-dockerfiles branch October 1, 2025 17:07
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants