-
Notifications
You must be signed in to change notification settings - Fork 18
BRE-1158 Dockerfiles shared ownership #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 78.48% 78.48%
=======================================
Files 276 276
Lines 27435 27435
=======================================
Hits 21531 21531
Misses 5904 5904 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do we want to exclude the current dockerfile since it's only the memory testing util which is solely for testing memory behaviour in CI and will never be published anywhere? |
|
I'm inclined to include the current dockerfile. This change is part of an effort to help maintain these internal practices. |
…les shared ownership (bitwarden/sdk-internal#460)
🎟️ Tracking
BRE-1158
📔 Objective
Include AppSec team and BRE dept for repository-level ownership of Dockerfile, and Dockerfile related, files.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes