Skip to content

Conversation

@nikwithak
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25821

📔 Objective

Migrates the logic for orchestrating API calls for several operations related to the Admin API functionality.

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details37d4cad1-ea61-4c24-94da-c1662a6f38b8

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: vault/pm-25821/cipher-admin-ops (f89f43d)
Completed: 2025-11-15 01:03:57 UTC
Total Time: 245s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 5.00000% with 342 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.88%. Comparing base (b033edd) to head (f89f43d).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/cipher.rs 1.63% 120 Missing ⚠️
.../bitwarden-vault/src/cipher/cipher_client/admin.rs 0.00% 113 Missing ⚠️
...bitwarden-vault/src/cipher/cipher_client/delete.rs 0.00% 66 Missing ⚠️
...s/bitwarden-vault/src/cipher/cipher_client/edit.rs 44.44% 20 Missing ⚠️
...es/bitwarden-vault/src/cipher/cipher_client/get.rs 0.00% 19 Missing ⚠️
...es/bitwarden-vault/src/cipher/cipher_client/mod.rs 0.00% 3 Missing ⚠️
...bitwarden-vault/src/cipher/cipher_client/create.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   79.70%   78.88%   -0.83%     
==========================================
  Files         300      302       +2     
  Lines       32227    32584     +357     
==========================================
+ Hits        25686    25703      +17     
- Misses       6541     6881     +340     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants