Email the lease holder when an operator revokes their access - #8292
Email the lease holder when an operator revokes their access#8292maxkpower wants to merge 7 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed Code Review DetailsNo blocking findings. PR Metadata Assessment
|
e1f25bc to
f81d164
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pam/PM-42817/mail-request-decided #8292 +/- ##
====================================================================
Coverage ? 64.80%
====================================================================
Files ? 2606
Lines ? 112087
Branches ? 10037
====================================================================
Hits ? 72633
Misses ? 37034
Partials ? 2420 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f81d164 to
917d83d
Compare
917d83d to
18ea011
Compare
| <tbody> | ||
| <tr> | ||
| <td align="center" bgcolor="#175ddc" role="presentation" style="border:none;border-radius:20px;cursor:auto;mso-padding-alt:12px 24px;background:#175ddc;" valign="middle"> | ||
| <a href="{{{Url}}}" style="display:inline-block;background:#175ddc;color:#ffffff;font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:16px;font-weight:600;line-height:120%;margin:0;text-decoration:none;text-transform:none;padding:12px 24px;mso-padding-alt:0px;border-radius:20px;" target="_blank"> |
There was a problem hiding this comment.
Rendering unescaped input in handlebar/mustache template can lead to XSS attacks - high severity
Using {{{ }}} renders an unescaped string into the template. This means the developer is responsible for allowlisting all HTML strings that can be passed in.
Show fix
Remediation: Avoid {{{ }}} usage. Ignore this issue only if the HTML content you feed into it is static. Defend in depth against XSS attacks by using a strict CSP policy. If you must use HTML, sanitize it with a library such as DOMPurify.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-42817
📔 Objective
Emails a lease holder when an operator revokes their active access. The push already re-locks their client; this tells them why.
AccessLeaseAction.Revoked. A holder ending their own lease (Cancelled) receives nothing: mailing someone about their own action is what trains people to ignore the channel.pamStatusRevokedandpamAuditKindLeaseRevokedin the web vault. The product reserves "ended" for the holder's own action.This is a courtesy, not a control: the lease is already dead server side before the mail is composed.
Top of a four PR stack on
pam/uat. Sits on the decision notification PR.📸 Screenshots