Add Active Directory as a rotation target-system kind - #8303
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pam/uat #8303 +/- ##
========================================
Coverage 64.72% 64.72%
========================================
Files 2599 2599
Lines 111839 111839
Branches 10022 10022
========================================
Hits 72388 72388
Misses 37033 37033
Partials 2418 2418 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the addition of Code Review DetailsNo findings. |
On-premises Active Directory joins Entra, MSSQL and CustomScript as a connector kind the access connector can rotate against. It is distinct from Entra, which is Entra ID. The server does not branch on Kind: the value is stored and handed to the daemon on the rotation claim, so no connector-specific server logic is needed. dbo.PamTargetSystem.Kind is a bare TINYINT NULL with no check constraint, so the new value needs no migration -- an integration test now round-trips every kind to hold that.
dd4b6ba to
8a34d5f
Compare
🎟️ Tracking
📔 Objective
Adds on-premises Active Directory as a PAM rotation target-system kind.
PamTargetSystemKind.ActiveDirectory = 3, distinct fromEntra, which is Entra ID.rotation-server.alliumrecords the kind and names an ADsAMAccountNameas a kind-interpretedaccount_identity.dbo.PamTargetSystem.Kindis a bareTINYINT NULLwith no check constraint, and the integration test round-trips every kind to hold that.Kind. It is passed to the connector on the rotation claim, so there is no connector-specific server logic here.Bottom of a two PR stack. It also gates work in
sdk-internalandclients: both currently carry temporary stand-ins for the binding this produces, so this needs to reachmainbefore those can drop them.📸 Screenshots