Skip to content

Conversation

@mohitkhullar
Copy link
Contributor

@mohitkhullar mohitkhullar commented Jul 29, 2025

No description provided.

@mohitkhullar mohitkhullar requested a review from mponomar July 29, 2025 13:46
@mohitkhullar mohitkhullar force-pushed the handle_load branch 3 times, most recently from b52756e to 3b2d374 Compare July 29, 2025 16:31
@mohitkhullar
Copy link
Contributor Author

Thread 15 "appsock:4" hit Breakpoint 2, add_lru_evbuffer (clnt=clnt@entry=0x30ed540)
1: pending_connections = 0
2: clnt->state = CONNECTION_NEW
#1 0x000000000095d3b3 in add_rd_event (timeout=0x0, ev=0x2831e50, appdata=0x30ed460)
rd_hdr (dummyfd=, what=, arg=0x2b1f450)

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/617 tests failed ⚠.

The first 10 failing tests are:
updater_latency
unionpar_maxqueue
cldeadlock

mponomar
mponomar previously approved these changes Jul 29, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/617 tests failed ⚠.

The first 10 failing tests are:
disttxn [setup failure]
socksql_master_swings
insert_lots_large_tran_generated
unionpar_maxqueue
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/617 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_truncate
disttxn
sc_lotsoftables
insert_lots_ssl_generated
insert_lots_large_tran_generated
insert_lots
guid

@mohitkhullar mohitkhullar changed the title Handle load, don't close connections we just accepted don't close admin connections Aug 5, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/620 tests failed ⚠.

The first 10 failing tests are:
close_old_connections [setup failure]
sc_lotsoftables
catchup
queuedb_rollover
sc_swapfields_logicalsc_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants