Skip to content

Revert stuff #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Revert stuff #5428

merged 2 commits into from
Sep 25, 2025

Conversation

chands10
Copy link
Contributor

revert env vars

@chands10
Revert "Get hostname from sockpool+iam env var support"
f3d94ae 
This reverts commit 96f8dc2.

Signed-off-by: Salil Chandra <[email protected]>
@chands10
Revert "Add partial env var support for cdb2api"
e44abf3 
This reverts commit 0c1fde7.

Signed-off-by: Salil Chandra <[email protected]>
roborivers
roborivers suggested changes Sep 24, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 1/630 tests failed ⚠.

The first 10 failing tests are:
logfill_logput_window_generated

@chands10
Copy link
Contributor Author

ohh?

 comdb2test.tsk -S revert_stuff.R20250924.1 | grep failed
TZ environment variable not found, will default to America/New_York.
Submitted by cdb2test on Sep 24 16:04:04 2025 (failed).
Candidate revert_stuff.R20250924.1 test  analyze_new          sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  queueclustered       sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  rangeext             sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  read_committed       sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  sctest               sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  siasof               sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  simple_remsql        sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  sqlitestats_remsql   sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  yastDDLa             sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  yastR5a              sundev1 from sundev1 host -> failed.
Candidate revert_stuff.R20250924.1 test  yastR5b              sundev1 from sundev1 host -> failed.

@chands10 chands10 merged commit 5d6b2d1 into bloomberg:main Sep 25, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshatsikarwar akshatsikarwar akshatsikarwar approved these changes

+1 more reviewer

@roborivers roborivers roborivers requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chands10 @akshatsikarwar @roborivers