Add first blog post for temporal_rs and general Boa Temporal work#195
Merged
Add first blog post for temporal_rs and general Boa Temporal work#195
Conversation
HalidOdat
approved these changes
Jun 15, 2025
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Really nice work! Nice read! 👏
Just some minor non-blocking comments 😄
HalidOdat
reviewed
Jun 15, 2025
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
Co-authored-by: Haled Odat <8566042+HalidOdat@users.noreply.github.com>
jedel1043
requested changes
Jun 15, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Looks very nice. Sorry for the comment dump, I just had a lot of ideas on how to improve the grammar of some sections 😅
Also, maybe we should link to the corresponding specification of each built-in, in case people are curious and want to check them out.
blog/temporal-introduction.md
Outdated
Comment on lines
55
to
58
| So after the prototype was merged, the prototype was pulled out of Boa's | ||
| internal builtins and externalized into its own crate, | ||
| [`temporal_rs`][temporal-rs-repo], which then first landed behind an | ||
| experimental flag in Boa v0.18. |
Member
There was a problem hiding this comment.
Suggested change
| So after the prototype was merged, the prototype was pulled out of Boa's | |
| internal builtins and externalized into its own crate, | |
| [`temporal_rs`][temporal-rs-repo], which then first landed behind an | |
| experimental flag in Boa v0.18. | |
| So, after the prototype was merged, the prototype was pulled out of Boa's | |
| internal builtins and externalized into its own crate, | |
| [temporal_rs][temporal-rs-repo], which landed behind an | |
| experimental flag in Boa v0.18 at first. |
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
jedel1043
requested changes
Jun 15, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Very nice! Just found some small fixes, but it's looking pretty much ready IMO
blog/2025-06-15-temporal-impl-1.md
Outdated
|
|
||
| Once we've constructed `Now`, then we are off to the races! | ||
|
|
||
| In Boa, implementing `Now` is as easy the below implementation for |
Member
There was a problem hiding this comment.
Wording seems a bit wonky here. "is as easy the below" specifically
Member
Author
There was a problem hiding this comment.
Yeah, I tried rewording it in a new commit. Matching it up with the tone of "off to the races" is a bit odd I think.
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
jedel1043
approved these changes
Jun 15, 2025
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
An additional small comment that doesn't block the PR. Nice work!
Co-authored-by: José Julián Espina <jedel0124@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a first blog post discussing some of the general work on temporal and temporal_rs.
Let me know what you think / if you think there's anything else we should highlight here.