Implement proposal nonextensible-applies-to-private #4511
+35
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4511 +/- ##
==========================================
+ Coverage 47.24% 57.10% +9.85%
==========================================
Files 476 503 +27
Lines 46892 57464 +10572
==========================================
+ Hits 22154 32812 +10658
+ Misses 24738 24652 -86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
force-pushed
the
implement-nonextensible-applies-to-private
branch
from
4e040c4 to
2540fb2
Compare
jedel1043
force-pushed
the
implement-nonextensible-applies-to-private
branch
from
2540fb2 to
e010f53
Compare
jedel1043
added
enhancement
HalidOdat
approved these changes
Nov 17, 2025
Member
HalidOdat
left a comment
HalidOdat
left a comment
There was a problem hiding this comment.
Looks great! Just some minor nitpicks 😄
| ) -> JsResult<()> { | ||
| // 1. If the host is a web browser, then | ||
| // a. Perform ? HostEnsureCanAddPrivateElement(O). | ||
| if !self.extensible() { |
Member
There was a problem hiding this comment.
Suggestion: It would be nice if we added the spec step to know where this came from. 😄
Suggested change
| if !self.extensible() { | |
| // 1. If O.[[Extensible]] is false, throw a TypeError exception. | |
| // | |
| // NOTE: From <https://tc39.es/proposal-nonextensible-applies-to-private/#sec-privatefieldadd> | |
| if !self.extensible() { |
| (false, false) | ||
| }; | ||
|
|
||
| if !self.extensible() { |
Member
There was a problem hiding this comment.
Suggestion: Same here:
Suggested change
| if !self.extensible() { | |
| // 2. If O.[[Extensible]] is false, throw a TypeError exception. | |
| // | |
| // NOTE: From <https://tc39.es/proposal-nonextensible-applies-to-private/#sec-privatemethodoraccessoradd> | |
| if !self.extensible() { |
Comment on lines
+947
to
+955
| return if getter || setter { | ||
| Err(js_error!( | ||
| TypeError: "cannot add private accessor to non-extensible class instance" | ||
| )) | ||
| } else { | ||
| Err(js_error!( | ||
| TypeError: "cannot add private method to non-extensible class instance" | ||
| )) | ||
| }; |
Member
There was a problem hiding this comment.
Praise: I really like the error message Improvement 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
nonextensible-applies-to-privateproposal.Since it's such a small change and it's already on stage 3, I decided to not gate this behind the experimental feature.