# Refactor: Remove ForInIterator from Builtin/Intrinsic System#4689
Open
rajat552 wants to merge 5 commits intoboa-dev:mainfrom
Open
# Refactor: Remove ForInIterator from Builtin/Intrinsic System#4689rajat552 wants to merge 5 commits intoboa-dev:mainfrom
ForInIterator from Builtin/Intrinsic System#4689rajat552 wants to merge 5 commits intoboa-dev:mainfrom
Conversation
Contributor
Author
|
@jedel1043 review this pr and tell me if their is any issue |
Contributor
|
11 CIs are failing due to failed compilation. |
Test262 conformance changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4689 +/- ##
==========================================
+ Coverage 47.24% 56.65% +9.40%
==========================================
Files 476 548 +72
Lines 46892 60073 +13181
==========================================
+ Hits 22154 34033 +11879
- Misses 24738 26040 +1302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@zhuzhu81998 review my code i made required changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed
ForInIteratorfrom the builtin/intrinsic registration system.Why
The
for-initerator is an internal engine mechanism — it is never visible to JavaScript code.Therefore, it should not be registered as a builtin intrinsic like
ArrayorMap.This change is a cleanup and optimization:
Closes #4677