Skip to content

# Refactor: Remove ForInIterator from Builtin/Intrinsic System#4689

Open
rajat552 wants to merge 5 commits intoboa-dev:mainfrom
rajat552:refactor/for-in-iterator-not-builtin
Open

# Refactor: Remove ForInIterator from Builtin/Intrinsic System#4689
rajat552 wants to merge 5 commits intoboa-dev:mainfrom
rajat552:refactor/for-in-iterator-not-builtin

Conversation

@rajat552
Copy link
Contributor

Summary

Removed ForInIterator from the builtin/intrinsic registration system.


Why

The for-in iterator is an internal engine mechanism — it is never visible to JavaScript code.

Therefore, it should not be registered as a builtin intrinsic like Array or Map.

This change is a cleanup and optimization:

  • Reduces unnecessary intrinsic initialization
  • Aligns better with spec intent
  • Removes unnecessary runtime overhead

Closes #4677

@rajat552
Copy link
Contributor Author

@jedel1043 review this pr and tell me if their is any issue

@zhuzhu81998
Copy link
Contributor

11 CIs are failing due to failed compilation.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,862 52,862 0
Passed 49,497 49,497 0
Ignored 2,261 2,255 -6
Failed 1,104 1,110 +6
Panics 0 0 0
Conformance 93.63% 93.63% 0.00%

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.65%. Comparing base (6ddc2b4) to head (673fff5).
⚠️ Report is 675 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4689      +/-   ##
==========================================
+ Coverage   47.24%   56.65%   +9.40%     
==========================================
  Files         476      548      +72     
  Lines       46892    60073   +13181     
==========================================
+ Hits        22154    34033   +11879     
- Misses      24738    26040    +1302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rajat552
Copy link
Contributor Author

@zhuzhu81998 review my code i made required changes

@jedel1043 jedel1043 added Internal Category for changelog waiting-on-author Waiting on PR changes from the author labels Feb 25, 2026
@rajat552 rajat552 requested a review from a team as a code owner February 25, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Category for changelog waiting-on-author Waiting on PR changes from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

# Issue 4 — ForInIterator Should Not Be a Builtin Intrinsic

3 participants