regexp: mitigate ReDoS on ASCII inputs with PikeVM path#4698
regexp: mitigate ReDoS on ASCII inputs with PikeVM path#4698Flamki wants to merge 3 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Broken tests (1): |
ff48371 to
63d6611
Compare
|
Follow-up fix pushed in 63d6611. Addresses the CI failures from the previous run:
This should resolve the build/lint/fmt failures that were cascading across jobs. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4698 +/- ##
==========================================
+ Coverage 47.24% 57.07% +9.82%
==========================================
Files 476 549 +73
Lines 46892 60311 +13419
==========================================
+ Hits 22154 34421 +12267
- Misses 24738 25890 +1152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63d6611 to
91d9da4
Compare
|
@jedel1043 I did a full cleanup pass on rebased the branch onto latest
Current branch head: |
This Pull Request mitigates #4643.
It changes the following:
regress::Regexmatcher for PikeVM execution inRegExpobjects.RegExpBuiltinExec, avoiding pathological backtracking in common ReDoS cases such as(a+)+$.Notes:
regress.